Page MenuHomeFreeBSD
Differential D57066

LinuxKPI: Check the devclass of the parent device in dev_is_pci
ClosedPublic
Actions

Authored by jhb on May 18 2026, 3:22 PM.
Tags
None
Referenced Files
F170612002: D57066.id.diff
Sat, Sep 5, 3:35 PM
F170584044: D57066.diff
Sat, Sep 5, 12:43 PM
Unknown Object (File)
Sat, Sep 5, 12:07 AM
Unknown Object (File)
Thu, Sep 3, 8:23 AM
Unknown Object (File)
Thu, Sep 3, 8:02 AM
Unknown Object (File)
Wed, Sep 2, 12:30 PM
Unknown Object (File)
Tue, Sep 1, 3:44 PM
Unknown Object (File)
Tue, Sep 1, 2:11 PM
View All 70 Files
Subscribers
emaste
imp
linuxkpi

Details

Reviewers
bz
Commits
rG10f33a860388: LinuxKPI: Check the devclass of the parent device in dev_is_pci
rG36b17708b0db: LinuxKPI: Check the devclass of the parent device in dev_is_pci
rG6a043d0814a2: LinuxKPI: Check the devclass of the parent device in dev_is_pci
Summary

Fixes: c41d83548b6c ("LinuxKPI: pci.h add more defines and functions")
Sponsored by: Chelsio Communications

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.May 18 2026, 3:22 PM
Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptMay 18 2026, 3:22 PM
jhb requested review of this revision.May 18 2026, 3:22 PM
Harbormaster completed remote builds in B73191: Diff 178014.May 18 2026, 3:22 PM
jhb added a child revision: D56997: sys: Use is_pci_device instead of direct comparisons to devclasses.May 18 2026, 3:25 PM
bz accepted this revision.May 18 2026, 3:38 PM

We assume that parent it is not a drmn device. Given I added this, it was for mt76 back then likely, so this was clearly a bug.

This revision is now accepted and ready to land.May 18 2026, 3:38 PM
jhb added a comment.May 18 2026, 6:43 PM
In D57066#1307689, @bz wrote:

We assume that parent it is not a drmn device. Given I added this, it was for mt76 back then likely, so this was clearly a bug.

Well, it remains just as broken for drm as it was before. :)

Closed by commit rG6a043d0814a2: LinuxKPI: Check the devclass of the parent device in dev_is_pci (authored by jhb). · Explain WhyMay 18 2026, 6:53 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG6a043d0814a2: LinuxKPI: Check the devclass of the parent device in dev_is_pci.
jhb added a commit: rG36b17708b0db: LinuxKPI: Check the devclass of the parent device in dev_is_pci.Jun 23 2026, 4:31 PM
jhb added a commit: rG10f33a860388: LinuxKPI: Check the devclass of the parent device in dev_is_pci.Jun 23 2026, 7:11 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
4 lines

Diff 178026

View Options

sys/compat/linuxkpi/common/include/linux/pci.h

Loading...