Page MenuHomeFreeBSD
Differential D57066

LinuxKPI: Check the devclass of the parent device in dev_is_pci
ClosedPublic
Actions

Authored by jhb on Mon, May 18, 3:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 25, 4:41 PM
Unknown Object (File)
Mon, May 25, 1:52 AM
Unknown Object (File)
Fri, May 22, 8:22 PM
Unknown Object (File)
Fri, May 22, 12:53 AM
Unknown Object (File)
Fri, May 22, 12:41 AM
Unknown Object (File)
Thu, May 21, 11:00 PM
Unknown Object (File)
Thu, May 21, 2:10 AM
Unknown Object (File)
Wed, May 20, 12:56 PM
View All 11 Files
Subscribers
emaste
imp
linuxkpi

Details

Reviewers
bz
Commits
rG6a043d0814a2: LinuxKPI: Check the devclass of the parent device in dev_is_pci
Summary

Fixes: c41d83548b6c ("LinuxKPI: pci.h add more defines and functions")
Sponsored by: Chelsio Communications

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Mon, May 18, 3:22 PM
Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptMon, May 18, 3:22 PM
jhb requested review of this revision.Mon, May 18, 3:22 PM
Harbormaster completed remote builds in B73191: Diff 178014.Mon, May 18, 3:22 PM
jhb added a child revision: D56997: sys: Use is_pci_device instead of direct comparisons to devclasses.Mon, May 18, 3:25 PM
bz accepted this revision.Mon, May 18, 3:38 PM

We assume that parent it is not a drmn device. Given I added this, it was for mt76 back then likely, so this was clearly a bug.

This revision is now accepted and ready to land.Mon, May 18, 3:38 PM
jhb added a comment.Mon, May 18, 6:43 PM
In D57066#1307689, @bz wrote:

We assume that parent it is not a drmn device. Given I added this, it was for mt76 back then likely, so this was clearly a bug.

Well, it remains just as broken for drm as it was before. :)

Closed by commit rG6a043d0814a2: LinuxKPI: Check the devclass of the parent device in dev_is_pci (authored by jhb). · Explain WhyMon, May 18, 6:53 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG6a043d0814a2: LinuxKPI: Check the devclass of the parent device in dev_is_pci.

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
4 lines

Diff 178026

View Options

sys/compat/linuxkpi/common/include/linux/pci.h

Loading...