Page MenuHomeFreeBSD

blocklistd: Fix RFC1918 typo
ClosedPublic

Authored by jlduran on May 2 2026, 7:49 PM.
Tags
None
Referenced Files
F163540846: D56773.diff
Fri, Jul 24, 7:13 AM
Unknown Object (File)
Thu, Jul 23, 8:03 AM
Unknown Object (File)
Thu, Jul 23, 7:38 AM
Unknown Object (File)
Thu, Jul 23, 2:57 AM
Unknown Object (File)
Wed, Jul 22, 4:49 PM
Unknown Object (File)
Mon, Jul 20, 4:07 PM
Unknown Object (File)
Mon, Jul 20, 3:12 PM
Unknown Object (File)
Wed, Jul 15, 5:44 AM

Details

Summary

The address in the configuration file example was intended to be from
the 192.168.0.0/16 range of IPv4 private addresses (RFC1918).

Reported on mastodon.social at
https://mastodon.social/@asmodai/116316630762241486.

Fix submitted upstream by emaste@. Fixing locally first.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 72733
Build 69616: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.May 3 2026, 3:29 AM
This revision was automatically updated to reflect the committed changes.

To be honest, I really doubt it was the intention to have the RFC 1918 address block in this example. You should ask Christos about it. An excellent pool for documentation and examples is one of the RFC 5737 blocks, for example, 192.0.2.0/24.
FWIW, this apparent and important fix causes conflicts to merge for etcupdate(8) on every single host that I updated recently.

To be honest, I really doubt it was the intention to have the RFC 1918 address block in this example. You should ask Christos about it. An excellent pool for documentation and examples is one of the RFC 5737 blocks, for example, 192.0.2.0/24.

The change stems from: https://github.com/zoulasc/blocklist/commit/0719c4ce739aab8526b7c1456dc7a53110328152, committed by Christos. Using RFC 5737 blocks has been suggested, this change is in "the pipeline", mainly for the manual page.

EDIT: Corrected RFC number.

FWIW, this apparent and important fix causes conflicts to merge for etcupdate(8) on every single host that I updated recently.

As with most changes in /etc. This is the main reason I decided to omit it for the upcoming 15.1-RELEASE.