Page MenuHomeFreeBSD
Differential D56464

ahci(4): Add another device ID for Marvell 9128 SATA controller: 0x91a3
ClosedPublic
Actions

Authored by michaelo on Apr 17 2026, 9:19 AM.
Tags
None
Referenced Files
F157164712: D56464.id.diff
Mon, May 18, 10:45 PM
F157084412: D56464.id176268.diff
Mon, May 18, 8:36 AM
Unknown Object (File)
Mon, May 18, 6:31 AM
Unknown Object (File)
Mon, May 18, 6:24 AM
Unknown Object (File)
Mon, May 18, 2:20 AM
Unknown Object (File)
Mon, May 18, 2:15 AM
Unknown Object (File)
Sun, May 17, 5:14 AM
Unknown Object (File)
Sun, May 17, 5:09 AM
View All 38 Files
Subscribers
imp

Details

Reviewers
mav
jhb
Commits
rG65d75038f32c: ahci(4): Add another device ID for Marvell 9128 SATA controller: 0x91a3
rG487eeda542a7: ahci(4): Add another device ID for Marvell 9128 SATA controller: 0x91a3
rGbcef4427a470: ahci(4): Add another device ID for Marvell 9128 SATA controller: 0x91a3
rGc72edc2b2eb2: ahci(4): Add another device ID for Marvell 9128 SATA controller: 0x91a3
Summary

This was encountered on a Gigabyte GA-P55A-UD4 motherboard identifying itself
as:
ahci0@pci0:2:0:0: class=0x01018f rev=0x11 hdr=0x00 vendor=0x1b4b device=0x91a3 subvendor=0x1458 subdevice=0xb000

vendor     = 'Marvell Technology Group Ltd.'
class      = mass storage
subclass   = ATA

The physical chip has "88SE9128-NAA2" printed on it.

Similar code has been in Linux for a long time:
https://github.com/torvalds/linux/commit/50be5e3657cd2851a297dc0b3fd459f25829d29b

Co-authored-by: Michael Osipov <michaelo@FreeBSD.org>
PR: 288526

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 72282
Build 69165: arc lint + arc unit

Event Timeline

michaelo created this revision.Apr 17 2026, 9:19 AM
Herald added a subscriber: imp. · View Herald TranscriptApr 17 2026, 9:19 AM
michaelo requested review of this revision.Apr 17 2026, 9:19 AM
Harbormaster completed remote builds in B72281: Diff 175745.Apr 17 2026, 9:19 AM
michaelo updated this revision to Diff 175746.Apr 17 2026, 9:21 AM

Fix formatting

Harbormaster completed remote builds in B72282: Diff 175746.Apr 17 2026, 9:21 AM
jhb accepted this revision.Thu, Apr 23, 4:05 PM
jhb added inline comments.
sys/dev/ahci/ahci_pci.c
299

I would move this down to here to keep the IDs sorted.

This revision is now accepted and ready to land.Thu, Apr 23, 4:05 PM
michaelo added inline comments.Thu, Apr 23, 4:09 PM
sys/dev/ahci/ahci_pci.c
299

I see, I added it up there on purpose to retain the order of the device description, but I am fine with either.

michaelo updated this revision to Diff 176268.Thu, Apr 23, 4:17 PM

Sort as @jhb has advised

This revision now requires review to proceed.Thu, Apr 23, 4:17 PM
Harbormaster completed remote builds in B72483: Diff 176268.Thu, Apr 23, 4:17 PM
jhb accepted this revision.Thu, Apr 23, 4:39 PM
This revision is now accepted and ready to land.Thu, Apr 23, 4:39 PM
Closed by commit rGc72edc2b2eb2: ahci(4): Add another device ID for Marvell 9128 SATA controller: 0x91a3 (authored by John W <jwdevel@gmail.com>, committed by michaelo). · Explain WhyThu, Apr 23, 4:42 PM
This revision was automatically updated to reflect the committed changes.
michaelo added a commit: rGc72edc2b2eb2: ahci(4): Add another device ID for Marvell 9128 SATA controller: 0x91a3.
michaelo added a commit: rGbcef4427a470: ahci(4): Add another device ID for Marvell 9128 SATA controller: 0x91a3.Thu, Apr 30, 7:52 AM
michaelo added a commit: rG487eeda542a7: ahci(4): Add another device ID for Marvell 9128 SATA controller: 0x91a3.
michaelo added a commit: rG65d75038f32c: ahci(4): Add another device ID for Marvell 9128 SATA controller: 0x91a3.

Revision Contents
Changeset List

PathSize
sys/
dev/
ahci/
2 lines

Diff 175746

View Options

sys/dev/ahci/ahci_pci.c

Loading...