Page MenuHomeFreeBSD
Differential D56429

stand/libofw: make OF_hasprop() part of the library
ClosedPublic
Actions

Authored by mhorne on Thu, Apr 16, 4:16 PM.
Tags
None
Referenced Files
F153841991: D56429.id175670.diff
Fri, Apr 24, 4:44 AM
Unknown Object (File)
Wed, Apr 22, 6:46 AM
Unknown Object (File)
Wed, Apr 22, 6:32 AM
Unknown Object (File)
Wed, Apr 22, 5:09 AM
Unknown Object (File)
Wed, Apr 22, 4:52 AM
Unknown Object (File)
Wed, Apr 22, 2:41 AM
Unknown Object (File)
Mon, Apr 20, 7:29 AM
Unknown Object (File)
Sun, Apr 19, 7:55 PM
View All 15 Files
Subscribers
dab

Details

Reviewers
imp
manu
adrian
Commits
rG48a05f833c7d: stand/libofw: make OF_hasprop() part of the library
Summary

Currently it is only needed by powerpc ofwfdt.c, and defined statically
there. Make it available as part of libofw, mirroring what we have in
the kernel.

Two small tweaks are made to the implementation:

  1. Return type is changed to bool
  2. Return 'true' when OF_getproplen() == 0. This matches the expected semantics of the kernel version, described in OF_hasprop(9).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 72257
Build 69140: arc lint + arc unit

Event Timeline

mhorne created this revision.Thu, Apr 16, 4:16 PM
Herald added a subscriber: dab. · View Herald TranscriptThu, Apr 16, 4:16 PM
mhorne requested review of this revision.Thu, Apr 16, 4:16 PM
Harbormaster completed remote builds in B72257: Diff 175670.Thu, Apr 16, 4:16 PM
mhorne edited the summary of this revision. (Show Details)Thu, Apr 16, 4:21 PM
adrian added a comment.Thu, Apr 16, 4:28 PM

Looks good; do we have a manpage with the other OF_ methods?

mhorne added a comment.Thu, Apr 16, 4:37 PM
In D56429#1291890, @adrian wrote:

Looks good; do we have a manpage with the other OF_ methods?

Yes, they are all in one, OF_getprop.9. I did not look in depth for what might be missing.

manu accepted this revision.Thu, Apr 16, 5:44 PM
This revision is now accepted and ready to land.Thu, Apr 16, 5:44 PM
imp accepted this revision.Thu, Apr 16, 5:44 PM
adrian accepted this revision.Thu, Apr 16, 5:47 PM

ah it's already there. yay!

Closed by commit rG48a05f833c7d: stand/libofw: make OF_hasprop() part of the library (authored by mhorne). · Explain WhyThu, Apr 16, 5:50 PM
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rG48a05f833c7d: stand/libofw: make OF_hasprop() part of the library.

Revision Contents
Changeset List

PathSize
stand/
libofw/
1 line
7 lines
powerpc/
ofw/
6 lines

Diff 175670

View Options

stand/libofw/openfirm.h

Loading...
View Options

stand/libofw/openfirm.c

Loading...
View Options

stand/powerpc/ofw/ofwfdt.c

Loading...