Differential D56331

ucode: Add ucode match helper function
Needs ReviewPublic
Actions

Authored by aokblast on Thu, Apr 9, 1:31 PM.

Tags

None

Referenced Files

	F152611259: D56331.diff
	Thu, Apr 16, 12:04 AM

	Unknown Object (File)
	Tue, Apr 14, 3:23 PM

	Unknown Object (File)
	Sun, Apr 12, 1:12 PM

	Unknown Object (File)
	Sat, Apr 11, 5:42 PM

	Unknown Object (File)
	Fri, Apr 10, 6:25 AM

	Unknown Object (File)
	Fri, Apr 10, 1:34 AM

	Unknown Object (File)
	Fri, Apr 10, 12:22 AM

Subscribers

Details

Reviewers

kib
jhb

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 72081
Build 68964: arc lint + arc unit

Event Timeline

aokblast created this revision.Thu, Apr 9, 1:31 PM

Herald added a subscriber: imp. · View Herald TranscriptThu, Apr 9, 1:31 PM

aokblast requested review of this revision.Thu, Apr 9, 1:31 PM

Harbormaster completed remote builds in B72081: Diff 175180.Thu, Apr 9, 1:31 PM

aokblast added a child revision: D56332: rdseed: Disable rdseed on zen5.Thu, Apr 9, 1:31 PM

emaste added reviewers: kib, jhb.Thu, Apr 9, 3:35 PM

aokblast added inline comments.Thu, Apr 9, 3:36 PM

sys/x86/include/ucode.h
88	The code style will be fixed before merging

Can you explain why is it needed?

In D56331#1288977, @kib wrote:

Can you explain why is it needed?

This was used in https://reviews.freebsd.org/D56332, which was aimed at detecting a cpu bug and disable rdseed feature before the new version microcode fix. But since that revision is removed, it might not be useful now. But also since it is not uncommon to cpu vendor to have some fixes in their new microcode, this matching code here might still be useful in the future.

Revision Contents
Changeset List

Path

Size

sys/

x86/

include/

11 lines

x86/

27 lines

Diff 175180

sys/x86/include/ucode.h

Loading...

sys/x86/x86/ucode.c

Loading...