Page MenuHomeFreeBSD
Differential D56291

[OpenSSL] Add missing header file (openssl/ml_kem.h)
ClosedPublic
Actions

Authored by sunpoet on Tue, Apr 7, 1:18 PM.
Tags
None
Referenced Files
F153364525: D56291.id175360.diff
Mon, Apr 20, 5:48 PM
Unknown Object (File)
Sat, Apr 18, 9:47 PM
Unknown Object (File)
Sat, Apr 18, 9:47 PM
Unknown Object (File)
Sat, Apr 18, 10:21 AM
Unknown Object (File)
Sat, Apr 18, 9:50 AM
Unknown Object (File)
Sat, Apr 18, 7:47 AM
Unknown Object (File)
Sat, Apr 18, 7:10 AM
Unknown Object (File)
Sat, Apr 18, 3:47 AM
View All 20 Files
Subscribers
imp

Details

Reviewers
ngie
fluffy
Commits
rG98118af4f08a: [OpenSSL] Add missing header file (openssl/ml_kem.h)
Summary

Add missing header file (openssl/ml_kem.h) of OpenSSL 3.5

Test Plan

Check the existence of /usr/include/openssl/ml_kem.h

Diff Detail

Repository
rG FreeBSD src repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 72013
Build 68896: arc lint + arc unit

Event Timeline

sunpoet created this revision.Tue, Apr 7, 1:18 PM
Herald added a subscriber: imp. · View Herald TranscriptTue, Apr 7, 1:18 PM
sunpoet requested review of this revision.Tue, Apr 7, 1:18 PM
Harbormaster completed remote builds in B72013: Diff 175037.Tue, Apr 7, 1:18 PM
aokblast added a reviewer: fluffy.Tue, Apr 7, 1:27 PM
fluffy accepted this revision.Tue, Apr 7, 2:16 PM

Header must be provided, ossl_ml_kem_* functions are already presented in libcrypto.so

This revision is now accepted and ready to land.Tue, Apr 7, 2:16 PM
fluffy added a comment.Tue, Apr 7, 3:00 PM

Just reminder: stable/15 is affected too

ngie accepted this revision.Tue, Apr 7, 6:40 PM
In D56291#1287969, @fluffy wrote:

Just reminder: stable/15 is affected too

Yes -- it'll need to be back ported to stable/15 and the relevant releng branches as well.

fluffy added a comment.Sun, Apr 12, 12:36 PM

@ngie you've updated openssl in main and stable/15 but still missed this include :(

10a428653ee7216475f1ddce3fb4cbf1200319f8 was a good point to ship it

Closed by commit rG98118af4f08a: [OpenSSL] Add missing header file (openssl/ml_kem.h) (authored by sunpoet, committed by ngie). · Explain WhySun, Apr 12, 6:08 PM
This revision was automatically updated to reflect the committed changes.
ngie added a commit: rG98118af4f08a: [OpenSSL] Add missing header file (openssl/ml_kem.h).
ngie added a comment.Sun, Apr 12, 6:09 PM

@fluffy : I was hoping sunpoet@ would have done the commit, but I've gone and just pushed the change to :main . I'll handle the MFC after 3 days.

Revision Contents
Changeset List

PathSize
secure/
lib/
libcrypto/
2 lines

Diff 175037

View Options

secure/lib/libcrypto/Makefile

Loading...