MFC r300220,r300223
ClosedPublic
Actions

Authored by ngie on Jun 10 2016, 8:49 PM.

Details

Reviewers

kib
alc
cem

Commits

rS301833: Redo MFC r300220,r300223:
rS301831: MFC r300220,r300223:

Summary

MFC r300220,r300223

MFC r300220,r300223:

r300220 (by cem):

sys/vmmeter.h: Fix trivial '-Wsign-compare' warning in common header

Frankly, it doesn't make sense for vm_pageout_wakeup_thresh to have a negative
value (it is only ever set to a fraction of v_free_min, which is unsigned and
also obviously non-negative). But I'm not going to try and convert every
non-negative scalar in the VM to unsigned today, so just cast it for the
comparison.

r300223 (by cem):

vm/vm_page.h: Fix trivial '-Wpointer-sign' warning

pq_vcnt, as a count of real things, has no business being negative. It is only
ever initialized by a u_int counter.

The warning came from the atomic_add_int() in vm_pagequeue_cnt_add().

Rectify the warning by changing the variable to u_int. No functional change.

Suggested by: Clang 3.3

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4176
Build 4219: arc lint + arc unit

Event Timeline

ngie updated this revision to Diff 17499.Jun 10 2016, 8:49 PM

ngie retitled this revision from to MFC r300220,r300223.

ngie updated this object.

ngie edited the test plan for this revision. (Show Details)

ngie added a reviewer: cem.

ngie added subscribers: alc, kib.

Herald added a subscriber: imp. · View Herald TranscriptJun 10 2016, 8:49 PM

I'm sending the CR out to double-check whether or not this change should be committed to ^/stable/10 . The structure type is changing for "struct vm_pagequeue", but the change seems ok.

I've run make buildworld/buildkernel for amd64/i386. I'm going to run make tinderbox on arm/mips/powerpc/sparc64 as a sanity check.

kib accepted this revision.Jun 11 2016, 4:27 AM

kib added a reviewer: kib.

This revision is now accepted and ready to land.Jun 11 2016, 4:27 AM

alc accepted this revision.Jun 11 2016, 4:32 AM

alc added a reviewer: alc.

Closed by commit rS301831: MFC r300220,r300223: (authored by ngie). · Explain WhyJun 11 2016, 11:24 AM

This revision was automatically updated to reflect the committed changes.