Rather than trust that the compiler will lay out the stack frame the
way we expect it to, use a union to force the correct alignment.
MFC after: 1 week
Fixes: 616f47f176c3 ("tunefs: Fix alignment warning on arm64")
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 71947 Build 68830: arc lint + arc unit
Event Timeline
Comment Actions
You could also do something similar with the directory filling routine dir_clear_block() and the two functions that call it dir_insert() and dir_extend().
| sbin/tunefs/tunefs.c | ||
|---|---|---|
| 643 | Here we're adding a variable offset to the pointer before casting, we should assert that alignment is preserved but the union trick won't help us, and in fact a corrupt or manipulated file system can cause us to perform an unaligned read. | |
| 731 | Here we add a caller-provided offset to the pointer before casting, we should assert that alignment is preserved but the union trick won't help us. | |
| sbin/tunefs/tunefs.c | ||
|---|---|---|
| 643 | I mean, we know that it needs to be aligned at least enough for a struct direct given that it immediately uses offset 0 as such. That's why I suggested in the overall comment that __aligned would be useful if it works on stack vars to force over-alignment in these cases to just not worry about it. | |