Starting from the existing fmax{,f,l} functions I've added the fmaximum family, which handles NaN according to the newest standard (propagating it).
This commit is a PoC for GSoC.
Details
Details
- Reviewers
fuz - Group Reviewers
numerics - Commits
- rGe55db843ef45: lib/msun: Added fmaximum and fminimum family. Tests and man page
I've used fmaxmin_test.c as a base, adapting it to the new functions.
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 71854 Build 68737: arc lint + arc unit
Event Timeline
Comment Actions
Looks pretty reasonable, though I'll let Steve Kargl have the last word.
Needs a man page.
| lib/msun/Symbol.map | ||
|---|---|---|
| 320–322 | 15.0 is already out, CURRENT is at 16.0. | |
| lib/msun/src/s_fmaximum.c | ||
| 2 | We got rid of the /*- convention a while ago. | |
| lib/msun/tests/fmaximum_test.c | ||
| 60–63 ↗ | (On Diff #173630) | shouldn't this match your code better? |
Comment Actions
Sorry for the delay, exam season is rough this year, but once I'm done I will follow up with the fminimum and man pages
Comment Actions
This looks pretty good.
I'll add a cross reference to math(3) on commit.
Will test a bit more and then land this patch set.
| lib/msun/src/s_fmaximumf.c | ||
|---|---|---|
| 34 | Clang and gcc don't seem to have these as built ins right now. It might be helpful to add a note on this to the commit message. | |
| lib/msun/tests/fmaximum_fminimum_test.c | ||
| 3 | If you have significantly adapted the code, do not hesitate to add your own copyright below. | |
Comment Actions
Two changes will be made before landing this:
- fminimum* and fmaximum* should never raise FE_INVALID
- build scripts should be alphabetised
For both changes I have sent a patch to the author to review. Will land afterwards.