Page MenuHomeFreeBSD
Differential D56230

fmax.3: Add caveat for going beyond C std requirements
ClosedPublic
Actions

Authored by emaste on Apr 2 2026, 10:04 PM.
Tags
None
Referenced Files
F166873279: D56230.id174987.diff
Mon, Aug 17, 9:43 AM
Unknown Object (File)
Mon, Aug 10, 10:39 AM
Unknown Object (File)
Sun, Aug 9, 2:37 AM
Unknown Object (File)
Wed, Aug 5, 7:58 AM
Unknown Object (File)
Wed, Aug 5, 3:40 AM
Unknown Object (File)
Tue, Aug 4, 9:23 AM
Unknown Object (File)
Tue, Aug 4, 9:14 AM
Unknown Object (File)
Sun, Aug 2, 7:57 AM
View All 58 Files
Subscribers
imp
jesuscblazquez_gmail.com
ziaee

Details

Reviewers
fuz
Commits
rGdc6149102509: fmax.3: Add caveat for going beyond C std requirements
rG855507463e0d: fmax.3: Add caveat for going beyond C std requirements
rG7764e9ca28a9: fmax.3: Add caveat for going beyond C std requirements
Summary
libm's fmax and fmin family of functions treat +0.0 as greater than
-0.0.  This is not required by the C standard, so the user may not see
this behaviour due to compiler optimization.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste created this revision.Apr 2 2026, 10:04 PM
Herald added a subscriber: ziaee. · View Herald TranscriptApr 2 2026, 10:04 PM
emaste requested review of this revision.Apr 2 2026, 10:04 PM
fuz accepted this revision.Apr 2 2026, 10:11 PM
fuz added a subscriber: jesuscblazquez_gmail.com.

Once we get fmaximum_num and fminimum_num in, we should recommend that those be used instead. CC @jesuscblazquez_gmail.com.

This revision is now accepted and ready to land.Apr 2 2026, 10:11 PM
jesuscblazquez_gmail.com mentioned this in D56236: lib/msun: Added fmaximum_mag and fmaximum_num families. Tests and man.Apr 3 2026, 2:59 PM
fuz added a child revision: D56236: lib/msun: Added fmaximum_mag and fmaximum_num families. Tests and man.Apr 3 2026, 11:54 PM
Closed by commit rG7764e9ca28a9: fmax.3: Add caveat for going beyond C std requirements (authored by emaste). · Explain WhyApr 6 2026, 5:00 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rG7764e9ca28a9: fmax.3: Add caveat for going beyond C std requirements.
Herald added a subscriber: imp. · View Herald TranscriptApr 6 2026, 5:00 PM
fuz mentioned this in rG4e30c12973c7: lib/msun: Added fmaximum_mag and fmaximum_num families.Apr 11 2026, 6:10 PM
emaste added a commit: rG855507463e0d: fmax.3: Add caveat for going beyond C std requirements.Apr 13 2026, 5:36 PM
emaste added a commit: rGdc6149102509: fmax.3: Add caveat for going beyond C std requirements.Apr 13 2026, 5:43 PM
fuz mentioned this in rG0073b3d572af: lib/msun: Added fmaximum_mag and fmaximum_num families.May 4 2026, 6:48 AM

Revision Contents
Changeset List

PathSize
lib/
msun/
man/
13 lines

Diff 174987

View Options

lib/msun/man/fmax.3

Loading...