sfxge(4): handle negative ticks difference correctly
ClosedPublic
Actions

Authored by arybchik on Jun 8 2016, 6:06 PM.

Details

Reviewers

philip
np
gnn
bz

Commits

rS301724: sfxge(4): handle negative ticks difference correctly

Summary

ticks are signed int and if statistics is not updated for a long time
(more than INT_MAX ticks, but less than UINT_MAX) difference becomes
negative and less than hz for a long time.

Other option to repeat is simply load driver (which initializes
timestamps to 0) when ticks are negative.

Sponsored by: Solarflare Communications, Inc.
MFC after: 1 week

Test Plan

Module built, loaded, sysctl stats checked.
Stats tested on a lucky host with negative ticks.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arybchik updated this revision to Diff 17429.Jun 8 2016, 6:06 PM

arybchik retitled this revision from to sfxge(4): handle negative ticks difference correctly.

arybchik updated this object.

arybchik edited the test plan for this revision. (Show Details)

arybchik added reviewers: gnn, philip, bz, np.

Herald added a subscriber: imp. · View Herald TranscriptJun 8 2016, 6:06 PM

Closed by commit rS301724: sfxge(4): handle negative ticks difference correctly (authored by arybchik). · Explain WhyJun 9 2016, 12:29 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

sfxge/

sfxge_ev.c

2 lines

sfxge_port.c

4 lines

Diff 17459

View Options

head/sys/dev/sfxge/sfxge_ev.c