Paths

Table of Contentst

Differential D56085

kern_mib: remove kern.fallback_elf_brand compat sysctl
ClosedPublic
Actions

Authored by chris.longros_gmail.com on Mar 25 2026, 2:06 PM.

Tags

None

Referenced Files

	F170973550: D56085.id174293.diff
	Mon, Sep 7, 11:05 PM

	Unknown Object (File)
	Sat, Sep 5, 8:04 AM

	Unknown Object (File)
	Sat, Sep 5, 8:01 AM

	Unknown Object (File)
	Sat, Sep 5, 6:59 AM

	Unknown Object (File)
	Sat, Sep 5, 1:00 AM

	Unknown Object (File)
	Sat, Sep 5, 12:28 AM

	Unknown Object (File)
	Sat, Sep 5, 12:28 AM

	Unknown Object (File)
	Fri, Sep 4, 6:12 PM

View All 77 Files

Subscribers

Details

Reviewers

kib
emaste

Commits

rGef03c60246be: kern_mib: remove kern.fallback_elf_brand compat sysctl

Summary

This compatibility alias for kern.elf{32,64}.fallback_brand has been
marked for removal since FreeBSD 6.0.

Signed-off-by: Christos Longros <chris.longros@gmail.com>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 71716
Build 68599: arc lint + arc unit

Event Timeline

chris.longros_gmail.com created this revision.Mar 25 2026, 2:06 PM

Herald added subscribers: olce, imp. · View Herald TranscriptMar 25 2026, 2:06 PM

chris.longros_gmail.com requested review of this revision.Mar 25 2026, 2:06 PM

Harbormaster completed remote builds in B71716: Diff 174293.Mar 25 2026, 2:06 PM

chris.longros_gmail.com added a reviewer: kib.Mar 25 2026, 2:09 PM

Does the extern declaration for __elfN(fallback_brand) in sys/sys/imgact_elf.h is needed after the patch? Could the __elfN(fallback_brand) var made static in kern_elf.c?

Good point. Updated the made __elfN(fallback_brand) from extern to static in imgact_elf.c.

make fallback_brand static, remove extern

Harbormaster completed remote builds in B71725: Diff 174344.Mar 26 2026, 6:47 PM

kib accepted this revision.Mar 27 2026, 2:04 AM

This revision is now accepted and ready to land.Mar 27 2026, 2:04 AM

@kib Hi, could you commit this when you time? Thanks!

kib added a reviewer: emaste.Apr 17 2026, 10:11 PM

Any updates regarding this patch ? :) @emaste @kib

Please ask @emaste to merge.

Note that these are currently accessed in libexec/rc/rc.d/linux:

# Handle unbranded ELF executables by defaulting to ELFOSABI_LINUX.
if [ `sysctl -ni kern.elf64.fallback_brand` -eq "-1" ]; then
        sysctl kern.elf64.fallback_brand=3 > /dev/null
fi

if [ `sysctl -ni kern.elf32.fallback_brand` -eq "-1" ]; then
        sysctl kern.elf32.fallback_brand=3 > /dev/null
fi

Was introduced in commit rG:e548a1d4c8cce0f67b82d6d5387847c7551de6c4

Closed by commit rGef03c60246be: kern_mib: remove kern.fallback_elf_brand compat sysctl (authored by chris.longros_gmail.com, committed by emaste). · Explain WhyMon, Aug 31, 5:34 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rGef03c60246be: kern_mib: remove kern.fallback_elf_brand compat sysctl.

Revision Contents
Changeset List

Path

Size

sys/

kern/

6 lines

tools/

tools/

sysdoc/

3 lines

Diff 174293

sys/kern/kern_mib.c

Loading...

tools/tools/sysdoc/tunables.mdoc

Loading...