Page MenuHomeFreeBSD
Differential D6777

sfxge(4): handle negative ticks difference correctly
ClosedPublic
Actions

Authored by arybchik on Jun 8 2016, 6:06 PM.
Tags
None
Referenced Files
F149820998: D6777.id.diff
Fri, Mar 27, 8:49 AM
F149813132: D6777.id17429.diff
Fri, Mar 27, 7:15 AM
F149804116: D6777.id17459.diff
Fri, Mar 27, 5:48 AM
Unknown Object (File)
Wed, Mar 25, 9:17 AM
Unknown Object (File)
Sat, Mar 21, 4:53 AM
Unknown Object (File)
Mon, Mar 9, 7:45 PM
Unknown Object (File)
Sun, Mar 8, 9:45 PM
Unknown Object (File)
Tue, Mar 3, 1:00 AM
View All 89 Files
Subscribers
imp

Details

Reviewers
philip
np
gnn
bz
Commits
rS301724: sfxge(4): handle negative ticks difference correctly
Summary

ticks are signed int and if statistics is not updated for a long time
(more than INT_MAX ticks, but less than UINT_MAX) difference becomes
negative and less than hz for a long time.

Other option to repeat is simply load driver (which initializes
timestamps to 0) when ticks are negative.

Sponsored by: Solarflare Communications, Inc.
MFC after: 1 week

Test Plan

Module built, loaded, sysctl stats checked.
Stats tested on a lucky host with negative ticks.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 4150
Build 4193: arc lint + arc unit

Event Timeline

arybchik updated this revision to Diff 17429.Jun 8 2016, 6:06 PM
arybchik retitled this revision from to sfxge(4): handle negative ticks difference correctly.
arybchik updated this object.
arybchik edited the test plan for this revision. (Show Details)
arybchik added reviewers: gnn, philip, bz, np.
Herald added a subscriber: imp. · View Herald TranscriptJun 8 2016, 6:06 PM
Closed by commit rS301724: sfxge(4): handle negative ticks difference correctly (authored by arybchik). · Explain WhyJun 9 2016, 12:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
sfxge/
2 lines
4 lines

Diff 17429

View Options

head/sys/dev/sfxge/sfxge_ev.c

Loading...
View Options

head/sys/dev/sfxge/sfxge_port.c

Loading...