fenv.h: stop declaring feclearexcept() extern inline
ClosedPublic
Actions

Authored by kib on Thu, Mar 19, 8:42 PM.

Details

Reviewers

emaste
dim
andrew

Commits

rGf39754d51b7d: fenv.h: stop declaring feclearexcept() extern inline

Summary

The function is already exported from libm.  We only need to stop
declare it extern inline, and instead provide a macro which uses the
internal inline function __feclearexcept_int() instead.

PR:     277958

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kib created this revision.Thu, Mar 19, 8:42 PM

Herald added a subscriber: imp. · View Herald TranscriptThu, Mar 19, 8:42 PM

I only handled x86 for start. After everybody is fine with the patch, I will add other arches.

Yeah, this looks fine to me. (Though I got confused initially by the _int suffix, until I understood that it's shorthand for internal... I was mislead by the int argument)

This revision is now accepted and ready to land.Thu, Mar 19, 8:48 PM

Handle all arches

This revision now requires review to proceed.Sun, Mar 22, 1:23 AM

Herald added a reviewer: andrew. · View Herald TranscriptSun, Mar 22, 1:23 AM

Herald added a reviewer: andrew. · View Herald Transcript

Do we need to handle the rest of the fenv functions same, they all are extern inline. Then we can remove the requirement to have gcc semantic for inline as a bonus.

This revision was not accepted when it landed; it landed in state Needs Review.Thu, Mar 26, 11:42 PM

Closed by commit rGf39754d51b7d: fenv.h: stop declaring feclearexcept() extern inline (authored by kib). · Explain Why

This revision was automatically updated to reflect the committed changes.

kib added a commit: rGf39754d51b7d: fenv.h: stop declaring feclearexcept() extern inline.