build: Add legacy support for futimens() and utimensat().
ClosedPublic
Actions

Authored by jilles on Jun 7 2016, 10:05 PM.

Details

Reviewers

Summary

In order to allow using utimensat() in install(1), add futimens() and
utimensat() to -legacy.

To simplify the code, no includes are installed for this. These functions
are declared in <sys/stat.h> and installing a header file to sys/ requires
additional make magic. The compilation flags are such that this will build
and the functions return int and are called with correct parameter types
and without using UTIME_OMIT and UTIME_NOW in install(1), so this should be
OK.

Test Plan

Revert rS299942 (which is a revert of rS299850) enabling nanosecond timestamps in install(1) and
make -j4 buildworld on recent stable/10 and in a chroot with releng/10.2.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

jilles updated this revision to Diff 17388.Jun 7 2016, 10:05 PM

jilles retitled this revision from to build: Add legacy support for futimens() and utimensat()..

jilles updated this object.

jilles edited the test plan for this revision. (Show Details)

jilles added a reviewer: bdrewery.

jilles set the repository for this revision to rS FreeBSD src repository - subversion.

jilles added a subscriber: bapt.

Herald added a subscriber: imp. · View Herald TranscriptJun 7 2016, 10:05 PM

jilles edited the test plan for this revision. (Show Details)Jun 7 2016, 10:07 PM

You should be able to use the existing source files in the tree.
(SRCTOP is a simpler version of .CURDIR/../../)

.PATH ${SRCTOP}/lib/libc/sys
CFLAGS+= -I${SRCTOP}/lib/libc/include

Then it will pull the existing futimens.c and utimensat.c from lib/libc/sys.

For installing sys/stat you can use something like this: https://people.freebsd.org/~bdrewery/patches/legacy-sys-example.diff

I meant .PATH: with colon

New patch with proper header file installation (thanks for the example).

I'm leaving futimens.c and utimensat.c as modified copies of the files under lib/libc/sys/ since the libc versions use symbols that do not exist in the libc on the build system (sys_futimens and sys_utimensat) . I expect the next non-sweeping change to both sets of files to be to delete them, anyway.

Herald added a subscriber: emaste. · View Herald TranscriptJun 8 2016, 8:18 PM

bdrewery accepted this revision.Jun 9 2016, 3:33 PM

bdrewery edited edge metadata.

This revision is now accepted and ready to land.Jun 9 2016, 3:33 PM

Committed as rS301763.