MFC after: 1 week
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 71416 Build 68299: arc lint + arc unit
Event Timeline
Comment Actions
I would get rid of the type changes, as I don't think they actually improve the code. The end_result change is wrong.
| usr.bin/m4/expr.c | ||
|---|---|---|
| 24 | This is an external variable in parser.y, the type int32_t is correct. If at all, it should be adjusted to YYSTYPE after including parser.h. | |
| 35 | Following style(9). | |
| usr.bin/m4/extern.h | ||
| 161 ↗ | (On Diff #173500) | I don't see the point of these type changes. |
| usr.bin/m4/look.c | ||
|---|---|---|
| 221 | ohash_first takes a pointer to an unsigned int. This change is incorrect. | |
| 254 | Same here. | |
| usr.bin/m4/parser.y | ||
| 21–22 | This change makes it so that the type of an m4 expression is potentially platform dependent. Is this desired? In particular, m4(1) documents that 32-bit arithmetic is used, so it should really stay int32_t. | |
| usr.bin/m4/expr.c | ||
|---|---|---|
| 35 | The first rule is to be consistent, and m4 consistently does not parenthesize its return values. | |