Page MenuHomeFreeBSD
Differential D55730

linuxkpi: Move `_RET_IP_` to <linux/instruction_pointer.h>
ClosedPublic
Actions

Authored by dumbbell on Mar 8 2026, 1:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 20, 9:30 PM
Unknown Object (File)
Thu, Apr 16, 4:02 PM
Unknown Object (File)
Wed, Apr 15, 6:49 PM
Unknown Object (File)
Sat, Apr 11, 4:37 PM
Unknown Object (File)
Mon, Apr 6, 9:55 PM
Unknown Object (File)
Sun, Apr 5, 11:49 AM
Unknown Object (File)
Sun, Apr 5, 1:40 AM
Unknown Object (File)
Wed, Apr 1, 5:53 PM
View All 20 Files
Subscribers
bz
emaste
imp
nc

Details

Reviewers
emaste
bz
Group Reviewers
linuxkpi
Commits
rG8af854ea479a: linuxkpi: Move `_RET_IP_` to <linux/instruction_pointer.h>
Summary

This matches the declaration on Linux.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dumbbell created this revision.Mar 8 2026, 1:18 PM
Herald added subscribers: emaste, imp. · View Herald TranscriptMar 8 2026, 1:18 PM
dumbbell requested review of this revision.Mar 8 2026, 1:18 PM
dumbbell edited the summary of this revision. (Show Details)
bz added subscribers: nc, bz.Mar 8 2026, 1:37 PM
bz added inline comments.
sys/compat/linuxkpi/common/include/linux/instruction_pointer.h
8

In theory the definition came from fee0d486ef34c by @nc (https://reviews.freebsd.org/D30707)

emaste accepted this revision as: emaste.Mar 8 2026, 3:19 PM
emaste added inline comments.
sys/compat/linuxkpi/common/include/linux/instruction_pointer.h
8

It did, although that commit did not add a copyright statement to the file it was added to. I think it doesn't much matter for the trivial content in this file. We can add a @nc copyright, but I think it would be the first one in the tree.

This revision is now accepted and ready to land.Mar 8 2026, 3:19 PM
imp added inline comments.Mar 8 2026, 3:37 PM
sys/compat/linuxkpi/common/include/linux/instruction_pointer.h
8

Is nc a big contrubutor? But all the ip in this file is from nc, so the copyright is misleading...

Also, i thought FF contracts were doing spdx exclusively now

emaste added inline comments.Mar 8 2026, 3:40 PM
sys/compat/linuxkpi/common/include/linux/instruction_pointer.h
8

Yes, for FF-sponsored work we can use SPDX-only.

dumbbell updated this revision to Diff 173381.Mar 8 2026, 8:52 PM

Fix copyright header and restore copyright of @nc

This revision now requires review to proceed.Mar 8 2026, 8:52 PM
bz accepted this revision.Sun, Mar 29, 11:06 PM
This revision is now accepted and ready to land.Sun, Mar 29, 11:06 PM
emaste accepted this revision.Sun, Mar 29, 11:57 PM
Closed by commit rG8af854ea479a: linuxkpi: Move `_RET_IP_` to <linux/instruction_pointer.h> (authored by dumbbell). · Explain WhyMon, Apr 6, 7:55 PM
This revision was automatically updated to reflect the committed changes.
dumbbell added a commit: rG8af854ea479a: linuxkpi: Move `_RET_IP_` to <linux/instruction_pointer.h>.

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
13 lines
3 lines

Diff 173381

View Options

sys/compat/linuxkpi/common/include/linux/instruction_pointer.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/kernel.h

Loading...