1.24.0, take maintainership
ClosedPublic
Actions

Authored by alven on Tue, Mar 3, 8:15 PM.

Details

Reviewers

arrowd
vvd
db
yuri

Commits

R11:a1246c57197e: textproc/groff: Update 1.23.0 => 1.24.0, take maintainership

Summary

Clarify LICENSE
Add LICENSE_FILE
Add DOCS and EXAMPLES options
Switch from custom to canonical EXAMPLESDIR
Pet portclippy(1) and portfmt(1)

Test Plan

For every {150amd64, 143amd64, 143i386}:

Successful poudriere testport
Successful run-testing

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 71162
Build 68045: arc lint + arc unit

Event Timeline

alven requested review of this revision.Tue, Mar 3, 8:15 PM

alven created this revision.

Harbormaster completed remote builds in B71162: Diff 173081.Tue, Mar 3, 8:15 PM

Why didn't you add your mentors to the list of reviewers?

textproc/groff/Makefile
22–30	I can't say anything about the correctness of this change.
46	Switch from custom to canonical EXAMPLESDIR Why? DOCSDIR have DISTVERSION in dir name, but default EXAMPLESDIR doesn't have.
49	CONFIGURE_ENV after CONFIGURE_ARGS look better for me.
56–58	Do this in `post-install-EXAMPLES-on` goal.
60	Do this in `post-install-DOCS-on` goal.
textproc/groff/files/mdoc.local
54–75	I can't say anything about the correctness of this change.

In D55637#1273128, @vvd wrote:

Why didn't you add your mentors to the list of reviewers?

Sorry. I did this as I was granted permission to commit my own changes without their review, so I still always mention them as subscribers.
But this port is a really difficult one, so I really do need their advice.

alven added inline comments.Tue, Mar 3, 10:30 PM

textproc/groff/Makefile
22–30	I've read configure- and Make-files and didn't find any mentions of 'missing' programs, so decided this is safe to remove... About awk, I remember it uses standard awk by default and builds without it. About `makeinfo`: Building groff no longer requires the makeinfo command. Since groff 1.23.0, we ship groff's Texinfo manual in several formats as part of groff's distribution archive [0]. [0] https://cgit.git.savannah.gnu.org/cgit/groff.git/tree/NEWS?h=1.24.0
46	This port is rather unusual as it install it's data and docs into versioned directories. And also installs examples in a subdirectory of ${DOCSDIR}. I tried to make things work in more streamlined and BSD-standard way, moving examples from this subdir into common standard ${EXAMPLESDIR}. In theory, I could try to do the same trick also with versioned docs and possibly, even ${DATADIR} (but here not sure, so prefered not to even try). MAKE_JOBS_UNSAFE isn't needed for build anymore as it builds OK without it now.
49	Well, I could easily move it there, as you like.
56–58	Well, I'll try to do this.
60	Well, I'll try to do this.
textproc/groff/files/mdoc.local
54–75	I've just removed lines already present in original doc-common [0], [1]: [0] https://cgit.git.savannah.gnu.org/cgit/groff.git/tree/tmac/mdoc/doc-common#n674 [1] https://cgit.git.savannah.gnu.org/cgit/groff.git/tree/tmac/mdoc/doc-common#n606

alven added inline comments.Tue, Mar 3, 10:43 PM

textproc/groff/Makefile
56–58	Actually, I tried to do what you adviced me, but realised, that as this port have examples installed into subdir of ${DOCSDIR}, this makes implicit dependence EXAMPLES on DOCS, whis is hard to notice and deal with. So I just decided to streamline things first in `post-install` doing all the splitting, and only then remove docs/examples/both following usual logic of options. This feels really "orthogonal" to me, and it worked well. I know, your decision is likely better, I may be just don't understand you now. Could you, please, share your version how it should look like for me to understand your plan? Thanks! And thanks for the whole review, of course! :)