textproc/groff: Update 1.23.0 => 1.24.0, take maintainership

[alven]

Summary

• Clarify LICENSE
• Add LICENSE_FILE
• Add DOCS and EXAMPLES options
• Switch from custom to canonical EXAMPLESDIR
• Pet portclippy(1) and portfmt(1)

Test Plan

For every {150amd64, 143amd64, 143i386}:

• Successful poudriere testport
• Successful run-testing

[vvd]

Why didn't you add your mentors to the list of reviewers?

textproc/groff/Makefile

22–30

I can't say anything about the correctness of this change.

46

Switch from custom to canonical EXAMPLESDIR

Why?
DOCSDIR have DISTVERSION in dir name, but default EXAMPLESDIR doesn't have.

56–58

Do this in post-install-EXAMPLES-on goal.

57

CONFIGURE_ENV after CONFIGURE_ARGS look better for me.

60

Do this in post-install-DOCS-on goal.

textproc/groff/files/mdoc.local

54–75

I can't say anything about the correctness of this change.

[alven]

In D55637#1273128, @vvd wrote:

Why didn't you add your mentors to the list of reviewers?

Sorry. I did this as I was granted permission to commit my own changes without their review, so I still always mention them as subscribers.
But this port is a really difficult one, so I really do need their advice.

[alven]

textproc/groff/Makefile

22–30

I've read configure- and Make-files and didn't find any mentions of 'missing' programs, so decided this is safe to remove...
About awk, I remember it uses standard awk by default and builds without it.
About makeinfo:

Building groff no longer requires the makeinfo command.  Since groff
   1.23.0, we ship groff's Texinfo manual in several formats as part of
   groff's distribution archive [0].

[0] https://cgit.git.savannah.gnu.org/cgit/groff.git/tree/NEWS?h=1.24.0

46

This port is rather unusual as it install it's data and docs into versioned directories. And also installs examples in a subdirectory of ${DOCSDIR}.
I tried to make things work in more streamlined and BSD-standard way, moving examples from this subdir into common standard ${EXAMPLESDIR}.
In theory, I could try to do the same trick also with versioned docs and possibly, even ${DATADIR} (but here not sure, so prefered not to even try).
MAKE_JOBS_UNSAFE isn't needed for build anymore as it builds OK without it now.

56–58

Well, I'll try to do this.

57

Well, I could easily move it there, as you like.

60

Well, I'll try to do this.

textproc/groff/files/mdoc.local

54–75

I've just removed lines already present in original doc-common [0], [1]:

[0] https://cgit.git.savannah.gnu.org/cgit/groff.git/tree/tmac/mdoc/doc-common#n674
[1] https://cgit.git.savannah.gnu.org/cgit/groff.git/tree/tmac/mdoc/doc-common#n606

[alven]

textproc/groff/Makefile

56–58

Actually, I tried to do what you adviced me, but realised, that as this port have examples installed into subdir of ${DOCSDIR}, this makes implicit dependence EXAMPLES on DOCS, whis is hard to notice and deal with.
So I just decided to streamline things first in post-install doing all the splitting, and only then remove docs/examples/both following usual logic of options. This feels really "orthogonal" to me, and it worked well.
I know, your decision is likely better, I may be just don't understand you now. Could you, please, share your version how it should look like for me to understand your plan? Thanks! And thanks for the whole review, of course! :)

[yuri]

Approved.

Yuri

[vvd]

textproc/groff/Makefile

56–58

@@ -1,5 +1,6 @@
 PORTNAME=      groff
 DISTVERSION=   1.24.0
+PORTREVISION=  1
 CATEGORIES=    textproc
 MASTER_SITES=  GNU

@@ -30,12 +31,12 @@ PAPERSIZE=  A4
 .if defined(PAPERSIZE)
 CONFIGURE_ENV+=        PAGE=${PAPERSIZE}
 .endif
+MAKE_ARGS=     datasubdir=${DATADIR} \
+               docdir=${DOCSDIR} \
+               exampledir=${EXAMPLESDIR}

 CONFLICTS=     heirloom-doctools ja-groff

-DATADIR=       ${PREFIX}/share/${PORTNAME}/${DISTVERSION}
-DOCSDIR=       ${PREFIX}/share/doc/${PORTNAME}-${DISTVERSION}
-
 INFO=          groff
 PORTDOCS=      *
 PORTEXAMPLES=  *
@@ -52,12 +53,10 @@ UCHARDET_CONFIGURE_OFF=     --with-uchardet=no
 post-install:
        ${INSTALL_DATA} ${FILESDIR}/mdoc.local ${STAGEDIR}${PREFIX}/share/groff/site-tmac
        ${REINPLACE_CMD} -i "" -e "s/missing/gs/" ${STAGEDIR}${DATADIR}/font/devhtml/DESC
+       ${RLN} . ${STAGEDIR}${DATADIR}/current

-       ${MKDIR} ${STAGEDIR}${EXAMPLESDIR}
-       cd ${STAGEDIR}${DOCSDIR}/examples && ${COPYTREE_SHARE} . ${STAGEDIR}${EXAMPLESDIR}
-       ${RM} -r ${STAGEDIR}${DOCSDIR}/examples
-
-       ${RLN} ${STAGEDIR}${EXAMPLESDIR}/mom/mom-pdf.pdf ${STAGEDIR}${DOCSDIR}/pdf
+post-install-DOCS-on:
+       ${LN} -f ${STAGEDIR}${EXAMPLESDIR}/mom/mom-pdf.pdf ${STAGEDIR}${DOCSDIR}/pdf

 post-install-DOCS-off:
        ${RM} -r ${STAGEDIR}${DOCSDIR}

[alven]

textproc/groff/Makefile

56–58

Thank you, Vladimir! You are a real friend, always kind and ready to help.
I really like and appreciate your patch, and would like to have enough knowledge to write such patches myself sometimes.