Remove struct proc p_sched and struct thread td_sched.
ClosedPublic
Actions

Authored by kib on Jun 3 2016, 9:55 PM.

Details

Reviewers

emaste
jhb

Commits

rS301456: Get rid of struct proc p_sched and struct thread td_sched pointers.

Summary

p_sched is unused.

td_sched is pointless, the corresponding memory is always next after the struct thread itself, except for thread0. The later is easily fixable, it only looks ugly. IMO it is better to remove the useless indirection.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kib updated this revision to Diff 17280.Jun 3 2016, 9:55 PM

kib retitled this revision from to Remove struct proc p_sched and struct thread td_sched..

kib updated this object.

kib edited the test plan for this revision. (Show Details)

kib added reviewers: jhb, emaste.

kib set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptJun 3 2016, 9:55 PM

Add pure2 attribute.

jhb accepted this revision.Jun 4 2016, 2:08 PM

jhb edited edge metadata.

jhb added inline comments.

sys/kern/sched_ule.c
1628	Maybe use a 'struct td_sched *ts' helper var here so it's more readable?
sys/sys/proc.h
886	Perhaps move this up to just below 'struct thread' definition so all the types are together?

This revision is now accepted and ready to land.Jun 4 2016, 2:08 PM

Move the struct thread0_storage right after the struct thread.
For several sched_ule.c functions, reduce number of td_get_sched() calls by using local vars.
Reorganize asserts about thread0_storage layout, making it static and correcting the size of the tail (reducing it to correct size).

This revision now requires review to proceed.Jun 4 2016, 4:32 PM

Closed by commit rS301456: Get rid of struct proc p_sched and struct thread td_sched pointers. (authored by kib). · Explain WhyJun 5 2016, 5:04 PM

This revision was automatically updated to reflect the committed changes.