Use the UEFI timer on arm64,the RTC may not be available
ClosedPublic
Actions

Authored by andrew on Jun 3 2016, 12:01 PM.

Details

Reviewers

emaste
jhb
imp
smh

Commits

rS301306: Use the UEFI event timer to update the time on arm and arm64. The current

Summary

The existing EFI timer code calls RS->GetTime. This doesn't seem
to be available on many arm64 platforms. Replace it with a timer that
increments evert 10ms.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4097
Build 4140: arc lint + arc unit

Event Timeline

andrew updated this revision to Diff 17268.Jun 3 2016, 12:01 PM

andrew retitled this revision from to Use the UEFI timer on arm64,the RTC may not be available.

andrew updated this object.

andrew edited the test plan for this revision. (Show Details)

andrew added reviewers: emaste, imp, smh.

andrew added inline comments.Jun 3 2016, 12:02 PM

sys/boot/efi/libefi/time_event.c
1–2	This file wasn't copied, but git seems to think so due to the similar license.

emaste added inline comments.Jun 3 2016, 12:33 PM

sys/boot/efi/libefi/Makefile
16–20	Do you think it would make sense to just use the same code in both cases?
17	blank line?
sys/boot/efi/libefi/time_event.c
1–2	Yeah, probably because the non-license-block content in the both the old and new files is rather small.

andrew added inline comments.Jun 3 2016, 1:05 PM

sys/boot/efi/libefi/Makefile
16–20	I didn't because it is untested there. I got the idea from grub where they still use the GetTime functions in x86.
17	Merge conflict, should be one line higher