Calendars: Update status reports deadlines
Needs ReviewPublic
Actions

Authored by salvadore on Tue, Feb 24, 4:25 PM.

Details

Reviewers

adamw
imp
cperciva
gperciva_tarsnap.com

Summary

Also move the deadlines in their own calendar file.

Reported by: jhs

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 70982
Build 67865: arc lint + arc unit

Event Timeline

salvadore requested review of this revision.Tue, Feb 24, 4:25 PM

salvadore created this revision.

Harbormaster completed remote builds in B70960: Diff 172609.Tue, Feb 24, 4:25 PM

I'm not familiar with the calendar syntax, but calendar.freebsd has format date desc whereas calendar.status_reports has date: desc. Just making sure that that's intentional and acceptable. Other than that, these dates and descriptions all look correct to me.

Replace ": " with tab.

Harbormaster completed remote builds in B70982: Diff 172656.Wed, Feb 25, 8:10 AM

gperciva_tarsnap.com added inline comments.Wed, Feb 25, 10:16 PM

usr.bin/calendar/calendars/calendar.status_reports
15	June only has 30 days.
20	September only has 30 days.

Fix June and September last day of the month

Harbormaster completed remote builds in B71065: Diff 172864.Fri, Feb 27, 2:13 PM

Sorry, did you actually change the dates? It looks like the version on Phabricator still lists 6/31 and 9/31. Is the website slow to update the diff it displays?

In D55491#1271519, @gperciva_tarsnap.com wrote:

Sorry, did you actually change the dates? It looks like the version on Phabricator still lists 6/31 and 9/31. Is the website slow to update the diff it displays?

No no, he's updating ISO 8601, not this file, which'll take a minute. Committees and such.

In D55491#1271519, @gperciva_tarsnap.com wrote:

Sorry, did you actually change the dates? It looks like the version on Phabricator still lists 6/31 and 9/31. Is the website slow to update the diff it displays?

I thought I did, but apparently I did not... Sorry, I am using this simple review to relearn how to use arcanist and apparently I did something wrong. Let me try again.

Try again to fix last days of June and September

Harbormaster completed remote builds in B71089: Diff 172917.Sat, Feb 28, 7:39 AM

Ok, this time it worked. No idea what I did wrong the first time, I thought I had run the same exact command...