Page MenuHomeFreeBSD

ngctl: Fix getline loop
ClosedPublic

Authored by des on Feb 24 2026, 2:14 PM.
Tags
None
Referenced Files
F170079156: D55487.id172591.diff
Thu, Sep 3, 11:06 AM
F170014496: D55487.id.diff
Thu, Sep 3, 6:17 AM
Unknown Object (File)
Thu, Aug 27, 5:57 PM
Unknown Object (File)
Wed, Aug 26, 10:37 AM
Unknown Object (File)
Wed, Aug 12, 12:37 AM
Unknown Object (File)
Tue, Aug 11, 2:15 AM
Unknown Object (File)
Mon, Aug 10, 9:04 PM
Unknown Object (File)
Mon, Aug 10, 10:06 AM

Details

Summary

I misremembered when I wrote this code: getline() returns -1 on EOF, not
zero, so the loop condition and the error check are both incorrect.

MFC after: 3 days
Fixes: 3cbdcabf714d ("ngctl: Modernize code somewhat")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 70956
Build 67839: arc lint + arc unit