Page MenuHomeFreeBSD

ngctl: Fix getline loop
ClosedPublic

Authored by des on Feb 24 2026, 2:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 8, 9:51 AM
Unknown Object (File)
Sun, Apr 5, 8:58 PM
Unknown Object (File)
Sun, Apr 5, 1:10 PM
Unknown Object (File)
Sat, Mar 14, 3:57 PM
Unknown Object (File)
Mar 9 2026, 8:08 PM
Unknown Object (File)
Mar 9 2026, 8:08 PM
Unknown Object (File)
Mar 8 2026, 8:22 PM
Unknown Object (File)
Mar 3 2026, 11:58 PM

Details

Summary

I misremembered when I wrote this code: getline() returns -1 on EOF, not
zero, so the loop condition and the error check are both incorrect.

MFC after: 3 days
Fixes: 3cbdcabf714d ("ngctl: Modernize code somewhat")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 70956
Build 67839: arc lint + arc unit