Page MenuHomeFreeBSD
Differential D55482

system(3): Write our own tests
ClosedPublic
Actions

Authored by des on Tue, Feb 24, 1:44 PM.
Tags
None
Referenced Files
F146427622: D55482.diff
Mon, Mar 2, 3:06 PM
Unknown Object (File)
Sun, Mar 1, 2:24 PM
Unknown Object (File)
Sun, Mar 1, 4:14 AM
Unknown Object (File)
Sun, Mar 1, 3:33 AM
Unknown Object (File)
Sun, Mar 1, 3:33 AM
Unknown Object (File)
Sun, Mar 1, 2:25 AM
Unknown Object (File)
Thu, Feb 26, 10:12 AM
Unknown Object (File)
Thu, Feb 26, 10:11 AM
View All 17 Files
Subscribers
imp

Details

Reviewers
bnovkov
kevans
Group Reviewers
Klara
Commits
rG7a1ade5109ac: system(3): Write our own tests
Summary

Replace the somewhat perfunctory NetBSD tests with our own.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 70952
Build 67835: arc lint + arc unit

Event Timeline

des created this revision.Tue, Feb 24, 1:44 PM
Herald added a subscriber: imp. · View Herald TranscriptTue, Feb 24, 1:44 PM
des requested review of this revision.Tue, Feb 24, 1:44 PM
Harbormaster completed remote builds in B70952: Diff 172583.Tue, Feb 24, 1:44 PM
des added a child revision: D55483: system(3): Clarify return values.Tue, Feb 24, 1:44 PM
des added a parent revision: D55471: system(3): Improve signal handling.Tue, Feb 24, 1:44 PM
bnovkov accepted this revision as: bnovkov.Tue, Feb 24, 2:19 PM
This revision is now accepted and ready to land.Tue, Feb 24, 2:19 PM
des updated this revision to Diff 172615.Tue, Feb 24, 5:27 PM

fix race condition and procmask issues

This revision now requires review to proceed.Tue, Feb 24, 5:27 PM
Harbormaster completed remote builds in B70964: Diff 172615.Tue, Feb 24, 5:27 PM
kevans accepted this revision.Tue, Feb 24, 5:32 PM
This revision is now accepted and ready to land.Tue, Feb 24, 5:32 PM
des updated this revision to Diff 172617.Tue, Feb 24, 5:33 PM

expset is unused

This revision now requires review to proceed.Tue, Feb 24, 5:33 PM
Harbormaster completed remote builds in B70966: Diff 172617.Tue, Feb 24, 5:33 PM
kevans accepted this revision.Tue, Feb 24, 5:36 PM
This revision is now accepted and ready to land.Tue, Feb 24, 5:36 PM
Closed by commit rG7a1ade5109ac: system(3): Write our own tests (authored by des). · Explain WhyWed, Feb 25, 9:14 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG7a1ade5109ac: system(3): Write our own tests.

Revision Contents
Changeset List

PathSize
lib/
libc/
tests/
stdlib/
3 lines
141 lines

Diff 172583

View Options

lib/libc/tests/stdlib/Makefile

Loading...
View Options

lib/libc/tests/stdlib/system_test.c

Loading...