Differential D6705

sfxge(4): always be ready to receive batched events
ClosedPublic
Actions

Authored by arybchik on Jun 3 2016, 5:37 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 26, 9:40 AM

	Unknown Object (File)
	Mon, Nov 4, 5:14 AM

	Unknown Object (File)
	Mon, Nov 4, 5:13 AM

	Unknown Object (File)
	Mon, Nov 4, 5:13 AM

	Unknown Object (File)
	Mon, Nov 4, 5:00 AM

	Unknown Object (File)
	Fri, Nov 1, 2:37 PM

	Unknown Object (File)
	Sep 16 2024, 11:59 AM

	Unknown Object (File)
	Sep 15 2024, 12:27 PM

View All 66 Files

Subscribers

Details

Reviewers

philip
np
gnn
bz

Commits

rS301985: MFC r301309
rS301309: sfxge(4): always be ready to receive batched events

Summary

When the low-latency firmware variant is running, it is reported as not
being capable of batching RX events, but it can still do so if the
FORCE_EV_MERGING flag is set on an RXQ. Therefore we need to handle
batched RX events even if the capability isn't set.

If this bug is fixed in the firmware such that the capability is set
even when running the low-latency firmware variant, it will almost
always be reported so I don't think we lose much by removing the check.

Submitted by: Mark Spender <mspender at solarflare.com>
Sponsored by: Solarflare Communications, Inc.
MFC after: 1 week

Test Plan

Build tested.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 4092
Build 4135: arc lint + arc unit

Event Timeline

arybchik updated this revision to Diff 17257.Jun 3 2016, 5:37 AM

arybchik retitled this revision from to sfxge(4): always be ready to receive batched events.

arybchik updated this object.

arybchik edited the test plan for this revision. (Show Details)

arybchik added reviewers: gnn, philip, bz, np.

Herald added a subscriber: imp. · View Herald TranscriptJun 3 2016, 5:37 AM

Closed by commit rS301309: sfxge(4): always be ready to receive batched events (authored by arybchik). · Explain WhyJun 4 2016, 9:21 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

sfxge/

common/

7 lines

3 lines

Diff 17257

head/sys/dev/sfxge/common/ef10_nic.c

Loading...

head/sys/dev/sfxge/sfxge_ev.c

Loading...