Page MenuHomeFreeBSD
Differential D55445

snl: Remove duplicate rta_expires member in route parser
ClosedPublic
Actions

Authored by pouria on Sun, Feb 22, 6:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 6, 9:25 PM
Unknown Object (File)
Wed, Mar 4, 10:27 AM
Unknown Object (File)
Wed, Mar 4, 10:25 AM
Unknown Object (File)
Tue, Mar 3, 5:15 AM
Unknown Object (File)
Mon, Mar 2, 6:55 PM
Unknown Object (File)
Sun, Mar 1, 4:30 PM
Unknown Object (File)
Thu, Feb 26, 10:45 PM
Unknown Object (File)
Wed, Feb 25, 1:54 PM
View All 14 Files
Subscribers
glebius
imp
zarychtam_plan-b.pwste.edu.pl

Details

Reviewers
melifaro
Group Reviewers
network
Commits
rG82069fae3ff9: snl: Remove duplicate rta_expires member in route parser
Summary

There is no user for rta_expires member and it's
duplicate of rta_expire.
See D55442.

Test Plan

kyua test -k /usr/tests/sys/netlink/Kyuafile

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 70885
Build 67768: arc lint + arc unit

Event Timeline

pouria created this revision.Sun, Feb 22, 6:55 PM
Herald added subscribers: glebius, imp. · View Herald TranscriptSun, Feb 22, 6:55 PM
pouria requested review of this revision.Sun, Feb 22, 6:55 PM
Harbormaster completed remote builds in B70885: Diff 172459.Sun, Feb 22, 6:56 PM
melifaro accepted this revision.Thu, Feb 26, 11:36 PM
This revision is now accepted and ready to land.Thu, Feb 26, 11:36 PM
Closed by commit rG82069fae3ff9: snl: Remove duplicate rta_expires member in route parser (authored by pouria). · Explain WhyFri, Feb 27, 8:47 PM
This revision was automatically updated to reflect the committed changes.
pouria added a commit: rG82069fae3ff9: snl: Remove duplicate rta_expires member in route parser.
zarychtam_plan-b.pwste.edu.pl added a subscriber: zarychtam_plan-b.pwste.edu.pl.Wed, Mar 4, 5:06 AM

I have been testing this patch on a couple of computers for over a week now, and everything seems to work fine (at least I see no regression).

Revision Contents
Changeset List

PathSize
sys/
netlink/
1 line

Diff 172459

View Options

sys/netlink/netlink_snl_route_parsers.h

Loading...