Page MenuHomeFreeBSD
Differential D55400

lpd: Add timeout option
ClosedPublic
Actions

Authored by des on Fri, Feb 20, 4:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 25, 5:42 AM
Unknown Object (File)
Tue, Feb 24, 4:57 PM
Subscribers
imp
ziaee

Details

Reviewers
markj
Commits
rG56fbfd1ecdc7: lpd: Add timeout option
Summary

Set a 120-second receive timeout on all client connections, and add a
command-line option to change that value.

MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 70820
Build 67703: arc lint + arc unit

Event Timeline

des created this revision.Fri, Feb 20, 4:03 PM
Herald added subscribers: ziaee, imp. · View Herald TranscriptFri, Feb 20, 4:03 PM
des requested review of this revision.Fri, Feb 20, 4:03 PM
Harbormaster completed remote builds in B70820: Diff 172317.Fri, Feb 20, 4:03 PM
des added a parent revision: D55399: lpd: Improve robustness.Fri, Feb 20, 4:03 PM
des added a reviewer: markj.Fri, Feb 20, 4:05 PM
markj accepted this revision.Sat, Feb 21, 2:55 AM
markj added inline comments.
usr.sbin/lpr/lpd/lpd.c
393

Should we bother with a timeout in the domain == AF_UNIX case?

394
This revision is now accepted and ready to land.Sat, Feb 21, 2:55 AM
des added inline comments.Sat, Feb 21, 8:50 AM
usr.sbin/lpr/lpd/lpd.c
393

Why should we trust local unprivileged users more than we trust root on an authorized client?

Closed by commit rG56fbfd1ecdc7: lpd: Add timeout option (authored by des). · Explain WhyThu, Feb 26, 6:16 AM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG56fbfd1ecdc7: lpd: Add timeout option.

Revision Contents
Changeset List

PathSize
usr.sbin/
lpr/
lpd/
8 lines
30 lines

Diff 172317

View Options

usr.sbin/lpr/lpd/lpd.8

Loading...
View Options

usr.sbin/lpr/lpd/lpd.c

Loading...