lpd: Add timeout option
AcceptedPublic
Actions

Authored by des on Fri, Feb 20, 4:03 PM.

Details

Reviewers

markj

Summary

Set a 120-second receive timeout on all client connections, and add a
command-line option to change that value.

MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 70820
Build 67703: arc lint + arc unit

Event Timeline

des created this revision.Fri, Feb 20, 4:03 PM

Herald added subscribers: ziaee, imp. · View Herald TranscriptFri, Feb 20, 4:03 PM

des requested review of this revision.Fri, Feb 20, 4:03 PM

Harbormaster completed remote builds in B70820: Diff 172317.Fri, Feb 20, 4:03 PM

des added a parent revision: D55399: lpd: Improve robustness.Fri, Feb 20, 4:03 PM

des added a reviewer: markj.Fri, Feb 20, 4:05 PM

markj accepted this revision.Sat, Feb 21, 2:55 AM

markj added inline comments.

usr.sbin/lpr/lpd/lpd.c
393	Should we bother with a timeout in the `domain == AF_UNIX` case?
394

This revision is now accepted and ready to land.Sat, Feb 21, 2:55 AM

des added inline comments.Sat, Feb 21, 8:50 AM

usr.sbin/lpr/lpd/lpd.c
393	Why should we trust local unprivileged users more than we trust root on an authorized client?

Revision Contents
Changeset List

Path

Size

usr.sbin/

lpr/

lpd/

lpd.8

8 lines

lpd.c

30 lines

Diff 172317

View Options

usr.sbin/lpr/lpd/lpd.8