Paths

Table of Contentst

Differential D55383

syslogd/tests: use kern.features to detect INET support
ClosedPublic
Actions

Authored by siva on Feb 19 2026, 8:34 PM.

Tags

None

Referenced Files

	F153291466: D55383.diff
	Mon, Apr 20, 7:10 AM

	F153253653: D55383.id172281.diff
	Mon, Apr 20, 2:16 AM

	Unknown Object (File)
	Sat, Apr 18, 9:30 PM

	Unknown Object (File)
	Wed, Apr 15, 12:20 AM

	Unknown Object (File)
	Thu, Apr 9, 1:29 AM

	Unknown Object (File)
	Wed, Apr 8, 9:50 AM

	Unknown Object (File)
	Wed, Apr 8, 2:56 AM

	Unknown Object (File)
	Sun, Apr 5, 1:08 PM

View All 27 Files

Subscribers

Details

Reviewers

markj
emaste
lwhsu

Commits

rG47911892a029: syslogd/tests: use kern.features to detect INET support
rGc721ceeb3ef0: syslogd/tests: use kern.features to detect INET support

Summary

This fixes INET feature detection with kernel configs
that do not include the kern.conftxt sysctl, such as
riscv64 currently[0].

[0] https://ci.freebsd.org/view/Test/job/FreeBSD-main-riscv64-test/16514/testReport/usr.sbin.syslogd/syslogd_forwarded_format_test/O_flag_bsd_forwarded_legacy/

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 70801
Build 67684: arc lint + arc unit

Event Timeline

siva created this revision.Feb 19 2026, 8:34 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 19 2026, 8:34 PM

siva requested review of this revision.Feb 19 2026, 8:34 PM

Harbormaster completed remote builds in B70800: Diff 172281.Feb 19 2026, 8:34 PM

markj accepted this revision.Feb 19 2026, 8:40 PM

markj added inline comments.

usr.sbin/syslogd/tests/syslogd_format_test_common.sh
51	Otherwise you'll get a warning if the sysctl doesn't exist, since the `-eq` operator expects integer operands, but in that case the LHS will be the empty string.

This revision is now accepted and ready to land.Feb 19 2026, 8:40 PM

LGTM with @markj's comment addressed

Applied feedback, will commit this version.

This revision now requires review to proceed.Feb 19 2026, 8:49 PM

Harbormaster completed remote builds in B70801: Diff 172282.Feb 19 2026, 8:49 PM

emaste accepted this revision.Feb 19 2026, 8:50 PM

This revision is now accepted and ready to land.Feb 19 2026, 8:50 PM

markj accepted this revision.Feb 19 2026, 8:56 PM

Closed by commit rGc721ceeb3ef0: syslogd/tests: use kern.features to detect INET support (authored by siva). · Explain WhyFeb 19 2026, 9:22 PM

This revision was automatically updated to reflect the committed changes.

siva added a commit: rGc721ceeb3ef0: syslogd/tests: use kern.features to detect INET support.

siva added a commit: rG47911892a029: syslogd/tests: use kern.features to detect INET support.Feb 24 2026, 1:06 AM

Revision Contents
Changeset List

Path

Size

usr.sbin/

syslogd/

tests/

syslogd_format_test_common.sh

3 lines

Diff 172282

usr.sbin/syslogd/tests/syslogd_format_test_common.sh

Loading...