Page MenuHomeFreeBSD
Differential D55383

syslogd/tests: use kern.features to detect INET support
ClosedPublic
Actions

Authored by siva on Thu, Feb 19, 8:34 PM.
Tags
None
Referenced Files
F146072200: D55383.id172281.diff
Fri, Feb 27, 1:51 PM
Unknown Object (File)
Fri, Feb 27, 12:14 AM
Unknown Object (File)
Thu, Feb 26, 4:14 PM
Unknown Object (File)
Thu, Feb 26, 2:37 PM
Unknown Object (File)
Thu, Feb 26, 12:41 PM
Unknown Object (File)
Thu, Feb 26, 11:15 AM
Unknown Object (File)
Thu, Feb 26, 7:31 AM
Unknown Object (File)
Thu, Feb 26, 7:22 AM
View All 12 Files
Subscribers
imp

Details

Reviewers
markj
emaste
lwhsu
Commits
rG47911892a029: syslogd/tests: use kern.features to detect INET support
rGc721ceeb3ef0: syslogd/tests: use kern.features to detect INET support
Summary

This fixes INET feature detection with kernel configs
that do not include the kern.conftxt sysctl, such as
riscv64 currently[0].

[0] https://ci.freebsd.org/view/Test/job/FreeBSD-main-riscv64-test/16514/testReport/usr.sbin.syslogd/syslogd_forwarded_format_test/O_flag_bsd_forwarded_legacy/

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 70800
Build 67683: arc lint + arc unit

Event Timeline

siva created this revision.Thu, Feb 19, 8:34 PM
Herald added a subscriber: imp. · View Herald TranscriptThu, Feb 19, 8:34 PM
siva requested review of this revision.Thu, Feb 19, 8:34 PM
Harbormaster completed remote builds in B70800: Diff 172281.Thu, Feb 19, 8:34 PM
markj accepted this revision.Thu, Feb 19, 8:40 PM
markj added inline comments.
usr.sbin/syslogd/tests/syslogd_format_test_common.sh
51

Otherwise you'll get a warning if the sysctl doesn't exist, since the -eq operator expects integer operands, but in that case the LHS will be the empty string.

This revision is now accepted and ready to land.Thu, Feb 19, 8:40 PM
emaste added a comment.Thu, Feb 19, 8:48 PM

LGTM with @markj's comment addressed

siva updated this revision to Diff 172282.Thu, Feb 19, 8:49 PM

Applied feedback, will commit this version.

This revision now requires review to proceed.Thu, Feb 19, 8:49 PM
Harbormaster completed remote builds in B70801: Diff 172282.Thu, Feb 19, 8:49 PM
emaste accepted this revision.Thu, Feb 19, 8:50 PM
This revision is now accepted and ready to land.Thu, Feb 19, 8:50 PM
markj accepted this revision.Thu, Feb 19, 8:56 PM
Closed by commit rGc721ceeb3ef0: syslogd/tests: use kern.features to detect INET support (authored by siva). · Explain WhyThu, Feb 19, 9:22 PM
This revision was automatically updated to reflect the committed changes.
siva added a commit: rGc721ceeb3ef0: syslogd/tests: use kern.features to detect INET support.
siva added a commit: rG47911892a029: syslogd/tests: use kern.features to detect INET support.Tue, Feb 24, 1:06 AM

Revision Contents
Changeset List

PathSize
usr.sbin/
syslogd/
tests/
3 lines

Diff 172281

View Options

usr.sbin/syslogd/tests/syslogd_format_test_common.sh

Loading...