Page MenuHomeFreeBSD
Differential D55343

bhyve: Fix unchecked stream I/O in RFB handler
ClosedPublic
Actions

Authored by hayzam_gmail.com on Feb 18 2026, 9:48 AM.
Tags
Referenced Files
Unknown Object (File)
Tue, Apr 21, 7:26 PM
Unknown Object (File)
Tue, Apr 21, 7:19 PM
Unknown Object (File)
Mon, Apr 20, 2:44 PM
Unknown Object (File)
Sun, Apr 19, 2:57 PM
Unknown Object (File)
Sun, Apr 19, 1:29 PM
Unknown Object (File)
Sun, Apr 19, 1:29 PM
Unknown Object (File)
Sun, Apr 19, 1:28 PM
Unknown Object (File)
Sun, Apr 19, 9:08 AM
View All 28 Files
Subscribers
bcran
imp
rgrimes

Details

Reviewers
markj
Group Reviewers
bhyve
Commits
rGd4420113e49d: bhyve: Fix unchecked stream I/O in RFB handler
rG818971cc403e: bhyve: Fix unchecked stream I/O in RFB handler
Summary

Convert rfb_send_* helpers to return status codes and check their results. Add missing checks for stream_read() and stream_write() returns during the handshake in rfb_handle() to avoid acting on failed I/O.

Sponsored by: The FreeBSD Foundation
Signed-off-by: Hayzam Sherif <hayzam@gmail.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

hayzam_gmail.com created this revision.Feb 18 2026, 9:48 AM
Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptFeb 18 2026, 9:48 AM
hayzam_gmail.com requested review of this revision.Feb 18 2026, 9:48 AM
hayzam_gmail.com added a reviewer: markj.Feb 18 2026, 9:51 AM
hayzam_gmail.com edited the summary of this revision. (Show Details)Feb 18 2026, 10:04 AM
markj added a comment.Feb 18 2026, 2:03 PM

When uploading a raw patch via the web UI, please be sure to add -U999999 per the guidance here: https://wiki.freebsd.org/Phabricator#Create_a_Revision_via_Web_Interface

Otherwise it's hard to read the patch due to missing context.

hayzam_gmail.com updated this revision to Diff 172149.Feb 18 2026, 2:10 PM

Regenerated diff with full context (-U999999) as requested

markj accepted this revision as: markj.Feb 19 2026, 7:21 PM
This revision is now accepted and ready to land.Feb 19 2026, 7:21 PM
Closed by commit rG818971cc403e: bhyve: Fix unchecked stream I/O in RFB handler (authored by hayzam_gmail.com, committed by markj). · Explain WhyFeb 19 2026, 7:41 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG818971cc403e: bhyve: Fix unchecked stream I/O in RFB handler.
markj added a commit: rGd4420113e49d: bhyve: Fix unchecked stream I/O in RFB handler.Tue, Mar 31, 3:59 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
76 lines

Diff 172280

View Options

usr.sbin/bhyve/rfb.c

Loading...