sysctl: Avoid calling priv_check() unnecessarily
ClosedPublic
Actions

Authored by markj on Thu, Feb 19, 5:01 PM.

Details

Reviewers

jhb
kib
olce

Commits

rG0fa6ce255661: sysctl: Avoid calling priv_check() unnecessarily

Summary

After commit 7d1d9cc440f80 we only serialize large sysctl requests for
non-root users, but we should avoid calling priv_check() unless the
request actually is large, as that's not the common case.

Fixes: 7d1d9cc440f8 ("sysctl: Do not serialize requests when running as root")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 70784
Build 67667: arc lint + arc unit

Event Timeline

markj created this revision.Thu, Feb 19, 5:01 PM

Herald added a subscriber: imp. · View Herald TranscriptThu, Feb 19, 5:01 PM

markj requested review of this revision.Thu, Feb 19, 5:01 PM

Harbormaster completed remote builds in B70784: Diff 172254.Thu, Feb 19, 5:01 PM

markj added a child revision: D55378: pipe: Avoid unnecessary priv_check() calls in pipespace_new().Thu, Feb 19, 5:01 PM

kib accepted this revision.Thu, Feb 19, 5:37 PM

This revision is now accepted and ready to land.Thu, Feb 19, 5:37 PM

olce accepted this revision.Thu, Feb 19, 6:06 PM

Closed by commit rG0fa6ce255661: sysctl: Avoid calling priv_check() unnecessarily (authored by markj). · Explain WhySat, Feb 21, 4:29 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG0fa6ce255661: sysctl: Avoid calling priv_check() unnecessarily.

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_sysctl.c

4 lines

Diff 172254

View Options

sysctl: Avoid calling priv_check() unnecessarilyClosedPublicActions