Page MenuHomeFreeBSD
Differential D54991

LinuxKPI: mod_devicetable, add comment about USB
ClosedPublic
Actions

Authored by bz on Sat, Jan 31, 12:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 4, 2:54 AM
Unknown Object (File)
Sun, Feb 1, 1:12 PM
Unknown Object (File)
Sun, Feb 1, 12:08 PM
Unknown Object (File)
Sun, Feb 1, 10:37 AM
Unknown Object (File)
Sun, Feb 1, 1:40 AM
Unknown Object (File)
Sun, Feb 1, 1:05 AM
Unknown Object (File)
Sat, Jan 31, 8:27 PM
Unknown Object (File)
Sat, Jan 31, 6:26 PM
Subscribers
dumbbell
emaste
imp

Details

Reviewers
dumbbell
Group Reviewers
linuxkpi
Commits
rG67a064decf92: LinuxKPI: mod_devicetable, add comment about [future] LinuxKPI USB
rG020ff5e29431: LinuxKPI: mod_devicetable, add comment about [future] LinuxKPI USB
Summary

USB structures are defined with the native USB implementation.
Just leave a comment why they are not here.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz created this revision.Sat, Jan 31, 12:48 AM
Herald added subscribers: emaste, imp. · View Herald TranscriptSat, Jan 31, 12:48 AM
bz requested review of this revision.Sat, Jan 31, 12:48 AM
Harbormaster completed remote builds in B70263: Diff 170822.Sat, Jan 31, 12:48 AM
bz added a parent revision: D54988: LinuxKPI: add commented out includes in pm.h.Sat, Jan 31, 12:49 AM
bz added a child revision: D55020: rtw88: set .bsddriver.name for USB chipsets.Sat, Jan 31, 8:06 PM
bz added a comment.Mon, Feb 9, 12:55 AM

This is a simple comment. Anyone any comments on it? Otherwise it'll go in within 48 hours.

dumbbell added a subscriber: dumbbell.Mon, Feb 9, 6:50 PM
dumbbell added inline comments.
sys/compat/linuxkpi/common/include/linux/mod_devicetable.h
87

I don’t understand what you mean here.

bz marked an inline comment as done.Mon, Feb 9, 7:06 PM
bz added inline comments.
sys/compat/linuxkpi/common/include/linux/mod_devicetable.h
87

Normally we would define struct usb_device_id here but the USB stack is tight into the native USB stack.
MODULE_DEVICE_TABLE_BUS_usb is (well will be, see somewhere in the stack) defined in usb.h.

This is similar to what we have in PCI (where all this is/was just in pci.h):
https://cgit.freebsd.org/src/blame/sys/compat/linuxkpi/common/include/linux/pci.h#n65 and following.

It is just now time to break this up so that further bus attachments (USB, SDIO) can be added.

dumbbell accepted this revision.Mon, Feb 9, 7:10 PM
dumbbell added inline comments.
sys/compat/linuxkpi/common/include/linux/mod_devicetable.h
87

Thanks for the clarification!

This revision is now accepted and ready to land.Mon, Feb 9, 7:10 PM
Closed by commit rG020ff5e29431: LinuxKPI: mod_devicetable, add comment about [future] LinuxKPI USB (authored by bz). · Explain WhyTue, Feb 10, 12:49 AM
This revision was automatically updated to reflect the committed changes.
bz marked an inline comment as done.
bz added a commit: rG020ff5e29431: LinuxKPI: mod_devicetable, add comment about [future] LinuxKPI USB.
bz added a commit: rG67a064decf92: LinuxKPI: mod_devicetable, add comment about [future] LinuxKPI USB.Fri, Feb 27, 2:30 AM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
6 lines

Diff 171608

View Options

sys/compat/linuxkpi/common/include/linux/mod_devicetable.h

Loading...