sfxge(4): zero should be used as RxQ label in SW event
ClosedPublic
Actions

Authored by arybchik on May 31 2016, 6:10 PM.

Details

Reviewers

philip
np
gnn
bz

Commits

rS301065: sfxge(4): zero should be used as RxQ label in SW event

Summary

The buggy code was using the rxq index but should use the evq label
associated with the rxq. It was missed in r298735.

Sponsored by: Solarflare Communications, Inc.
MFC after: 2 days

Test Plan

Build tested. Debug build with assertions enabled tested.
Always works fine now.

Further patches improve the code to avoid added KASSERT code
duplication.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 4052
Build 4095: arc lint + arc unit

Event Timeline

arybchik updated this revision to Diff 17154.May 31 2016, 6:10 PM

arybchik retitled this revision from to sfxge(4): zero should be used as RxQ label in SW event.

arybchik updated this object.

arybchik edited the test plan for this revision. (Show Details)

arybchik added reviewers: gnn, philip, np, bz.

Herald added a subscriber: imp. · View Herald TranscriptMay 31 2016, 6:10 PM

gnn accepted this revision.May 31 2016, 6:26 PM

gnn edited edge metadata.

This revision is now accepted and ready to land.May 31 2016, 6:26 PM

Closed by commit rS301065: sfxge(4): zero should be used as RxQ label in SW event (authored by arybchik). · Explain WhyMay 31 2016, 6:31 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

sfxge/

sfxge_rx.c

6 lines

Diff 17154

View Options

head/sys/dev/sfxge/sfxge_rx.c

sfxge(4): zero should be used as RxQ label in SW eventClosedPublicActions