Page MenuHomeFreeBSD
Differential D55029

LinuxKPI: add str_read_write()
ClosedPublic
Actions

Authored by bz on Sat, Jan 31, 11:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Feb 3, 11:14 PM
Unknown Object (File)
Tue, Feb 3, 10:48 PM
Unknown Object (File)
Mon, Feb 2, 11:11 AM
Unknown Object (File)
Sun, Feb 1, 3:36 PM
Unknown Object (File)
Sun, Feb 1, 3:02 PM
Unknown Object (File)
Sun, Feb 1, 11:07 AM
Subscribers
emaste
imp
kib

Details

Reviewers
emaste
kib
Group Reviewers
linuxkpi
Commits
rG6ea242cc305b: LinuxKPI: add str_read_write()
Summary

Needed by a wireless driver.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 70307
Build 67190: arc lint + arc unit

Event Timeline

bz created this revision.Sat, Jan 31, 11:18 PM
Herald added subscribers: emaste, imp. · View Herald TranscriptSat, Jan 31, 11:18 PM
bz requested review of this revision.Sat, Jan 31, 11:18 PM
Harbormaster completed remote builds in B70307: Diff 170916.Sat, Jan 31, 11:18 PM
bz added a child revision: D55035: LinuxKPI: usb: add usb_anchor support.Sun, Feb 1, 5:12 PM
bz removed a child revision: D55035: LinuxKPI: usb: add usb_anchor support.
bz added a parent revision: D54808: LinuxKPI: add scoped_guard(), spinlock guard support.Sun, Feb 1, 5:15 PM
kib added a subscriber: kib.Sun, Feb 1, 7:23 PM
kib added inline comments.
sys/compat/linuxkpi/common/include/linux/string_choices.h
77

return (value ? "read" : "write");
?

bz added inline comments.Sun, Feb 1, 7:54 PM
sys/compat/linuxkpi/common/include/linux/string_choices.h
77

Yes, but it's not the style of the file. If we want to do this we should adjust them all.

emaste accepted this revision.Sun, Feb 1, 8:17 PM

If we want to do this we should adjust them all.

OK, that could be a follow-up.

This revision is now accepted and ready to land.Sun, Feb 1, 8:17 PM
kib accepted this revision.Sun, Feb 1, 8:46 PM
bz added a comment.Mon, Feb 2, 10:41 PM
In D55029#1258032, @emaste wrote:

If we want to do this we should adjust them all.

OK, that could be a follow-up.

I'll do that.

Closed by commit rG6ea242cc305b: LinuxKPI: add str_read_write() (authored by bz). · Explain WhyTue, Feb 3, 6:40 PM
This revision was automatically updated to reflect the committed changes.
bz added a commit: rG6ea242cc305b: LinuxKPI: add str_read_write().
bz mentioned this in D55088: LinuxKPI: string_choices.h: use ternary operator.Tue, Feb 3, 6:52 PM
bz mentioned this in rG8df7af9c9ecf: LinuxKPI: string_choices.h: use ternary operator.Tue, Feb 3, 8:01 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
9 lines

Diff 170916

View Options

sys/compat/linuxkpi/common/include/linux/string_choices.h

Loading...