Differential D54808

LinuxKPI: add scoped_guard(), spinlock guard support
ClosedPublic
Actions

Authored by bz on Tue, Jan 20, 11:01 PM.

Details

Reviewers

None

Group Reviewers

linuxkpi

Commits

rG31393810a168: LinuxKPI: add scoped_guard(), spinlock guard support

Summary

The "cleanup.h" implementation got a bit more complicated.

For one we now use a macro to concatenate a prefix, the name, and a
suffix for variable and function declarations. This was triggered
by the fact that the "guard_" prefix we used was confusing. We now
use a generic "cleanup_" which is only encoded in the single place
rather than all over the file.

As already indicated by the comment the DEFINE_LOCK_GUARD_0()
macro got split up and a _1 version which also takes a type got
implemented and is used for a spinlock variant used by rtw89(4)
via the new scoped_guard() bits.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bz created this revision.Tue, Jan 20, 11:01 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptTue, Jan 20, 11:01 PM

bz requested review of this revision.Tue, Jan 20, 11:01 PM

Harbormaster completed remote builds in B70033: Diff 170163.Tue, Jan 20, 11:01 PM

bz added a child revision: D55029: LinuxKPI: add str_read_write().Sun, Feb 1, 5:15 PM

I would love to get this in before Monday if possible. In case anyone wants to review but does not have the time, please leave a comment and I'll wait even if not reviewed.

This revision was not accepted when it landed; it landed in state Needs Review.Tue, Feb 10, 12:49 AM

Closed by commit rG31393810a168: LinuxKPI: add scoped_guard(), spinlock guard support (authored by bz). · Explain Why

This revision was automatically updated to reflect the committed changes.

bz added a commit: rG31393810a168: LinuxKPI: add scoped_guard(), spinlock guard support.