Page MenuHomeFreeBSD

Add "iscsictl -e".
ClosedPublic

Authored by trasz on May 29 2016, 3:56 PM.
Tags
None
Referenced Files
F106670411: D6633.diff
Fri, Jan 3, 4:33 PM
Unknown Object (File)
Wed, Jan 1, 3:14 PM
Unknown Object (File)
Oct 12 2024, 11:28 PM
Unknown Object (File)
Oct 12 2024, 7:39 PM
Unknown Object (File)
Oct 9 2024, 8:33 AM
Unknown Object (File)
Sep 30 2024, 2:05 PM
Unknown Object (File)
Sep 21 2024, 4:37 AM
Unknown Object (File)
Sep 20 2024, 4:52 PM
Subscribers

Details

Summary

Add "iscsictl -e". This allows for having disabled sessions.

PR: 204129

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4024
Build 4067: arc lint + arc unit

Event Timeline

trasz retitled this revision from to Add "iscsictl -e"..
trasz updated this object.
trasz edited the test plan for this revision. (Show Details)
This revision was automatically updated to reflect the committed changes.
wblock added inline comments.
head/usr.bin/iscsictl/iscsi.conf.5
135 ↗(On Diff #17146)

It would be useful to the reader to briefly explain a possible use for this.

The "State" usage is kind of confusing. It can be read to mean that "state" is a value, but it is not used earlier. Maybe just say "value"? The default values can be shown at the same time, making for a shorter sentence:

Enable or disable the session.
A disabled session can be created, then enabled later when the krellium blootleforge is up to the right temperature.
Allowed values are
.Qq Ar On
(default), or
.Qq Ar Off .
head/usr.bin/iscsictl/iscsictl.8
118 ↗(On Diff #17146)
Ignored for discovery sessions, but passed down to normal sessions added by them.

Maybe. It's a little unclear.

And again, just a quick hint of how or why this is useful would be valuable to the reader.

200 ↗(On Diff #17146)

Please avoid semicolons, they are almost always better with just a full sentence break:

discovered target.
Use