Page MenuHomeFreeBSD
Differential D54842

vt.4: Document that hw.vga.textmode does not apply for UEFI(8) boot
ClosedPublic
Actions

Authored by michaelo on Fri, Jan 23, 8:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 2, 7:09 AM
Unknown Object (File)
Mon, Feb 2, 2:00 AM
Unknown Object (File)
Mon, Feb 2, 1:59 AM
Unknown Object (File)
Sun, Feb 1, 9:15 AM
Unknown Object (File)
Mon, Jan 26, 9:05 PM
Unknown Object (File)
Sun, Jan 25, 9:02 PM
Unknown Object (File)
Sun, Jan 25, 8:14 AM
Unknown Object (File)
Sun, Jan 25, 3:08 AM
View All 17 Files
Subscribers
imp

Details

Reviewers
ziaee
emaste
imp
Commits
rGeda3cd3c7a81: vt.4: Document that hw.vga.textmode does not apply for UEFI(8) boot
rG051d781bf9d6: vt.4: Document that hw.vga.textmode does not apply for UEFI(8) boot
rG4d36d18253b0: vt.4: Document that hw.vga.textmode does not apply for UEFI(8) boot
rG28764001b504: vt.4: Document that hw.vga.textmode does not apply for UEFI(8) boot
Summary

PR: 292598
Approved by: ziaee, emaste
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 70080
Build 66963: arc lint + arc unit

Event Timeline

michaelo created this revision.Fri, Jan 23, 8:07 PM
Herald added a subscriber: imp. · View Herald TranscriptFri, Jan 23, 8:07 PM
michaelo requested review of this revision.Fri, Jan 23, 8:07 PM
Harbormaster completed remote builds in B70080: Diff 170285.Fri, Jan 23, 8:07 PM
emaste added a comment.Fri, Jan 23, 8:11 PM

It's not so much that it's ignored, but UEFI boot does not use vga mode so the hw.vga tunables don't do anything. Maybe something like "Because UEFI boot does not use VGA mode, ..."?

ziaee added inline comments.Fri, Jan 23, 8:13 PM
share/man/man4/vt.4
204

I would instead do something like this

emaste added a comment.Fri, Jan 23, 8:13 PM

To expand on my comment - the reason I think it's worth mentioning that is to make it clear we haven't made a choice to ignore this tunable with UEFI, it's that it just doesn't apply with UEFI.

emaste added inline comments.Fri, Jan 23, 8:14 PM
share/man/man4/vt.4
204

Yes, that addresses my comment. Maybe "on systems that boot via legacy BIOS"?

michaelo added a comment.Fri, Jan 23, 8:15 PM
In D54842#1253714, @emaste wrote:

To expand on my comment - the reason I think it's worth mentioning that is to make it clear we haven't made a choice to ignore this tunable with UEFI, it's that it just doesn't apply with UEFI.

ACK

michaelo updated this revision to Diff 170287.Fri, Jan 23, 8:32 PM

Incorporate comments

Harbormaster completed remote builds in B70082: Diff 170287.Fri, Jan 23, 8:32 PM
ziaee added inline comments.Fri, Jan 23, 8:36 PM
share/man/man4/vt.4
204

That's fine with me, but I think that's a lot of extra words.

michaelo added inline comments.Fri, Jan 23, 8:44 PM
share/man/man4/vt.4
204

I used a more compact version.

ziaee accepted this revision.Fri, Jan 23, 8:57 PM
This revision is now accepted and ready to land.Fri, Jan 23, 8:57 PM
michaelo retitled this revision from vt.4: Document hw.vga.textmode is ignored in UEFI boot mode to vt.4: Document that hw.vga.textmode does not apply for UEFI(8) boot.Fri, Jan 23, 9:00 PM
ziaee added a comment.Fri, Jan 23, 9:08 PM

Many tools expect git commit titles to be 50 or less characters

imp accepted this revision.Sat, Jan 24, 1:46 AM
michaelo added a comment.Sat, Jan 24, 6:38 PM
In D54842#1253816, @ziaee wrote:

Many tools expect git commit titles to be 50 or less characters

50? You mean 80 or less.
Docs say 72: https://docs.freebsd.org/en/articles/committers-guide/#_limit_messages_to_72_columns

Closed by commit rG28764001b504: vt.4: Document that hw.vga.textmode does not apply for UEFI(8) boot (authored by michaelo). · Explain WhySat, Jan 24, 6:42 PM
This revision was automatically updated to reflect the committed changes.
michaelo added a commit: rG28764001b504: vt.4: Document that hw.vga.textmode does not apply for UEFI(8) boot.
michaelo added a commit: rG4d36d18253b0: vt.4: Document that hw.vga.textmode does not apply for UEFI(8) boot.Tue, Jan 27, 3:16 PM
michaelo added a commit: rG051d781bf9d6: vt.4: Document that hw.vga.textmode does not apply for UEFI(8) boot.
michaelo added a commit: rGeda3cd3c7a81: vt.4: Document that hw.vga.textmode does not apply for UEFI(8) boot.

Revision Contents
Changeset List

PathSize
share/
man/
man4/
3 lines

Diff 170285

View Options

share/man/man4/vt.4

Loading...