Page MenuHomeFreeBSD

syslogd/tests: Fix flakiness in forwarding tests
ClosedPublic

Authored by markj on Tue, Jan 20, 5:10 PM.
Tags
None
Referenced Files
F143925621: D54800.id170147.diff
Mon, Feb 2, 2:01 AM
F143925604: D54800.diff
Mon, Feb 2, 2:01 AM
Unknown Object (File)
Sat, Jan 31, 10:27 AM
Unknown Object (File)
Fri, Jan 30, 9:07 PM
Unknown Object (File)
Thu, Jan 29, 10:01 PM
Unknown Object (File)
Mon, Jan 26, 10:47 PM
Unknown Object (File)
Mon, Jan 26, 2:20 AM
Unknown Object (File)
Sun, Jan 25, 11:22 AM
Subscribers

Details

Summary

syslogd_start() waits for the local log socket to appear before
returning, to ensure that the daemon is ready to handle log messages.
Some tests start two daemons, so by default the socket already exists
when the second daemon is started, so syslogd_start() returns early.
The test subsequently sends a message to this second daemon, which
sometimes isn't ready.

Define a separate log socket for the second daemon. Add a check to
syslogd_start() to help catch this type of bug.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 70026
Build 66909: arc lint + arc unit

Event Timeline

I've seen that when using ATF, ${PWD} is preferred over $(pwd) (efficiency, I guess).

This revision is now accepted and ready to land.Tue, Jan 20, 5:58 PM
This revision now requires review to proceed.Tue, Jan 20, 7:28 PM
This revision is now accepted and ready to land.Tue, Jan 20, 7:52 PM