Page MenuHomeFreeBSD
Differential D54798

ext2fs: Simplify location of entries in an HTree index
Needs ReviewPublic
Actions

Authored by jhb on Tue, Jan 20, 3:59 PM.
Tags
None
Referenced Files
F142945506: D54798.diff
Sat, Jan 24, 9:15 PM
Unknown Object (File)
Sat, Jan 24, 7:22 AM
Unknown Object (File)
Fri, Jan 23, 7:45 AM
Unknown Object (File)
Thu, Jan 22, 8:10 AM
Unknown Object (File)
Wed, Jan 21, 1:56 PM
Unknown Object (File)
Wed, Jan 21, 3:00 AM
Unknown Object (File)
Tue, Jan 20, 9:36 PM
Unknown Object (File)
Tue, Jan 20, 9:29 PM
View All 10 Files
Subscribers
emaste
imp

Details

Reviewers
fsu
jrtc27
Group Reviewers
cheri
Summary

Just require a fixed size for h_info_len to permit using a simpler
assignment.

Obtained from: CheriBSD

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 70024
Build 66907: arc lint + arc unit

Event Timeline

jhb created this revision.Tue, Jan 20, 3:59 PM
Herald added a subscriber: imp. · View Herald TranscriptTue, Jan 20, 3:59 PM
jhb requested review of this revision.Tue, Jan 20, 3:59 PM
Herald added a reviewer: cheri. · View Herald TranscriptTue, Jan 20, 3:59 PM
Harbormaster completed remote builds in B70024: Diff 170134.Tue, Jan 20, 3:59 PM
jrtc27 added a comment.Tue, Jan 20, 4:05 PM

This probably needs more of an explanation for the issue with this pattern on CHERI than we had downstream

jhb added a comment.EditedWed, Jan 21, 3:56 PM

Hmm, I guess I could talk about subobject bounds and add 'Effort: CHERI' tag to it. My reasoning was that aside from CHERI, it is just more readable for upstream.

emaste added a subscriber: emaste.Wed, Jan 21, 5:24 PM

IMO it's worth putting all of that in the commit message -- that this came from CHERI and why, but also it's just generally better.

jhb added inline comments.Thu, Jan 22, 4:21 PM
sys/fs/ext2fs/ext2_htree.c
289

Hmmm, looking again at the Linux code in question, it doesn't check the length when mounting, but only in get_dx_countlimit() if rlen == 12.

Revision Contents
Changeset List

PathSize
sys/
fs/
ext2fs/
5 lines

Diff 170134

View Options

sys/fs/ext2fs/ext2_htree.c

Loading...