Page MenuHomeFreeBSD
Differential D54766

Add pthread_tryjoin_np(3) as provided by glibc
ClosedPublic
Actions

Authored by kib on Jan 18 2026, 12:56 PM.
Tags
None
Referenced Files
F175704401: D54766.id170008.diff
Mon, Oct 12, 3:51 PM
F175704399: D54766.id170059.diff
Mon, Oct 12, 3:51 PM
F175704353: D54766.id169999.diff
Mon, Oct 12, 3:51 PM
F175704158: D54766.id170046.diff
Mon, Oct 12, 3:49 PM
F175702912: D54766.diff
Mon, Oct 12, 3:38 PM
F175702582: D54766.id170059.diff
Mon, Oct 12, 3:35 PM
Unknown Object (File)
Fri, Oct 2, 12:31 PM
Unknown Object (File)
Wed, Sep 30, 11:25 PM
View All Files
Subscribers
imp
ziaee

Details

Reviewers
emaste
markj
Commits
rG902e3057cd5c: lib/libthr: add pthread_tryjoin(3) test
rG7f026a58691d: Document pthread_tryjoin_np(3)
rGafa70a8496e9: libthr: add pthread_tryjoin_np()
rGce16be73707e: libthr/thread/thr_join.c: deduplicate backout_join() helper
Summary
libthr/thread/thr_join.c: deduplicate backout_join() helper


libthr: add pthread_tryjoin_np()

Similar to the same glibc function.


Document pthread_tryjoin_np(3)


lib/libthr: add pthread_tryjoin(3) test

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Jan 18 2026, 12:56 PM
Herald added subscribers: ziaee, imp. · View Herald TranscriptJan 18 2026, 12:56 PM
kib requested review of this revision.Jan 18 2026, 12:56 PM
kib updated this revision to Diff 169999.Jan 18 2026, 1:12 PM

Convert test to the proper atf, instead of using err()

kib updated this revision to Diff 170008.Jan 18 2026, 3:03 PM

After a second thought, the pthread_tryjoin_np(3) function must be non-cancelling.

markj added inline comments.Jan 19 2026, 3:02 PM
lib/libthr/thread/thr_join.c
100

Why not just lock pthread in the caller? There is only one caller that passes thr_locked=false.

share/man/man3/pthread_join.3
112 ↗(On Diff #170008)
113 ↗(On Diff #170008)
114 ↗(On Diff #170008)
kib updated this revision to Diff 170046.Jan 19 2026, 3:55 PM
kib marked 4 inline comments as done.

Handle review' comments.

markj accepted this revision.Jan 19 2026, 4:48 PM
This revision is now accepted and ready to land.Jan 19 2026, 4:48 PM
Closed by commit rGce16be73707e: libthr/thread/thr_join.c: deduplicate backout_join() helper (authored by kib). · Explain WhyJan 19 2026, 4:58 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rGce16be73707e: libthr/thread/thr_join.c: deduplicate backout_join() helper.
kib added a commit: rGafa70a8496e9: libthr: add pthread_tryjoin_np().
kib added a commit: rG7f026a58691d: Document pthread_tryjoin_np(3).
kib added a commit: rG902e3057cd5c: lib/libthr: add pthread_tryjoin(3) test.

Revision Contents
Changeset List

PathSize
lib/
libthr/
thread/
21 lines

Diff 170059

View Options

lib/libthr/thread/thr_join.c

Loading...