Page MenuHomeFreeBSD
Differential D54766

Add pthread_tryjoin_np(3) as provided by glibc
ClosedPublic
Actions

Authored by kib on Sun, Jan 18, 12:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 21, 3:42 AM
Unknown Object (File)
Wed, Jan 21, 2:17 AM
Unknown Object (File)
Wed, Jan 21, 12:40 AM
Unknown Object (File)
Tue, Jan 20, 4:24 PM
Unknown Object (File)
Tue, Jan 20, 4:17 PM
Unknown Object (File)
Mon, Jan 19, 1:37 PM
Unknown Object (File)
Mon, Jan 19, 1:58 AM
Unknown Object (File)
Mon, Jan 19, 12:41 AM
View All 14 Files
Subscribers
imp
ziaee

Details

Reviewers
emaste
markj
Commits
rG902e3057cd5c: lib/libthr: add pthread_tryjoin(3) test
rG7f026a58691d: Document pthread_tryjoin_np(3)
rGafa70a8496e9: libthr: add pthread_tryjoin_np()
rGce16be73707e: libthr/thread/thr_join.c: deduplicate backout_join() helper
Summary
libthr/thread/thr_join.c: deduplicate backout_join() helper


libthr: add pthread_tryjoin_np()

Similar to the same glibc function.


Document pthread_tryjoin_np(3)


lib/libthr: add pthread_tryjoin(3) test

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib created this revision.Sun, Jan 18, 12:56 PM
Herald added subscribers: ziaee, imp. · View Herald TranscriptSun, Jan 18, 12:56 PM
kib requested review of this revision.Sun, Jan 18, 12:56 PM
kib updated this revision to Diff 169999.Sun, Jan 18, 1:12 PM

Convert test to the proper atf, instead of using err()

kib updated this revision to Diff 170008.Sun, Jan 18, 3:03 PM

After a second thought, the pthread_tryjoin_np(3) function must be non-cancelling.

markj added inline comments.Mon, Jan 19, 3:02 PM
lib/libthr/thread/thr_join.c
103

Why not just lock pthread in the caller? There is only one caller that passes thr_locked=false.

share/man/man3/pthread_join.3
112
113
114
kib updated this revision to Diff 170046.Mon, Jan 19, 3:55 PM
kib marked 4 inline comments as done.

Handle review' comments.

markj accepted this revision.Mon, Jan 19, 4:48 PM
This revision is now accepted and ready to land.Mon, Jan 19, 4:48 PM
Closed by commit rGce16be73707e: libthr/thread/thr_join.c: deduplicate backout_join() helper (authored by kib). · Explain WhyMon, Jan 19, 4:58 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rGce16be73707e: libthr/thread/thr_join.c: deduplicate backout_join() helper.
kib added a commit: rGafa70a8496e9: libthr: add pthread_tryjoin_np().
kib added a commit: rG7f026a58691d: Document pthread_tryjoin_np(3).
kib added a commit: rG902e3057cd5c: lib/libthr: add pthread_tryjoin(3) test.

Revision Contents
Changeset List

PathSize
include/
1 line
lib/
libthr/
4 lines
tests/
1 line
62 lines
thread/
76 lines
share/
man/
man3/
3 lines
26 lines

Diff 170046

View Options

include/pthread_np.h

Loading...
View Options

lib/libthr/pthread.map

Loading...
View Options

lib/libthr/tests/Makefile

Loading...
View Options

lib/libthr/tests/pthread_tryjoin_test.c

Loading...
View Options

lib/libthr/thread/thr_join.c

Loading...
View Options

share/man/man3/Makefile

Loading...
View Options

share/man/man3/pthread_join.3

Loading...