Page MenuHomeFreeBSD
Differential D54757

depend-cleanup.sh: Move pwd to a safer place
Needs ReviewPublic
Actions

Authored by aokblast on Sat, Jan 17, 1:26 PM.
Tags
None
Referenced Files
F143035667: D54757.id169987.diff
Sun, Jan 25, 10:14 AM
F143003235: D54757.id169947.diff
Sun, Jan 25, 5:23 AM
Unknown Object (File)
Thu, Jan 22, 5:21 PM
Unknown Object (File)
Wed, Jan 21, 8:32 AM
Unknown Object (File)
Tue, Jan 20, 9:04 PM
Unknown Object (File)
Sun, Jan 18, 7:45 PM
Unknown Object (File)
Sun, Jan 18, 6:44 PM
Unknown Object (File)
Sun, Jan 18, 2:15 PM
View All 15 Files
Subscribers
imp
jrtc27

Details

Reviewers
markj
jrtc27
imp
Summary

When using bear -- make buildworld, the bear failed on getcwd in this function.
This is because the interceptor want to use getcwd on a deleted
directory. We move the pwd out from the $OBJTOP.

Notice that any operation on $OBJTOP should be invalid after calling rm.
As a result, it is safe to move to any place.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 69946
Build 66829: arc lint + arc unit

Event Timeline

aokblast created this revision.Sat, Jan 17, 1:26 PM
Herald added subscribers: jrtc27, imp. · View Herald TranscriptSat, Jan 17, 1:26 PM
aokblast requested review of this revision.Sat, Jan 17, 1:26 PM
Harbormaster completed remote builds in B69946: Diff 169947.Sat, Jan 17, 1:26 PM
aokblast edited the summary of this revision. (Show Details)Sat, Jan 17, 1:28 PM
aokblast added a reviewer: markj.
aokblast edited the summary of this revision. (Show Details)Sat, Jan 17, 1:33 PM
aokblast added reviewers: jrtc27, imp.
aokblast edited the summary of this revision. (Show Details)
jrtc27 added a comment.Sat, Jan 17, 2:28 PM

I don’t understand, other than it sounding like bear is broken

aokblast added a comment.EditedSat, Jan 17, 2:47 PM
In D54757#1251272, @jrtc27 wrote:

I don’t understand, other than it sounding like bear is broken

Sorry, the commit message is not clear. I try to explain with more detail. Please tell me if you need anymore information.

When

pwd == $OBJTOP

, and after

run rm -rf "$OBJTOP"

getcwd(3) will return with error since the directory is deleted.

Under this condition:

When shell is executing:

mkdir -p "$OBJTOP"

bear intercepts the libc exec(3) function call and call getcwd in here. As a result, it causes an error.

jrtc27 added a comment.Sat, Jan 17, 3:00 PM
In D54757#1251288, @aokblast wrote:
In D54757#1251272, @jrtc27 wrote:

I don’t understand, other than it sounding like bear is broken

Sorry, the commit message is not clear. I try to explain with more detail. Please tell me if you need anymore information.

When

pwd == $OBJTOP

, and after

run rm -rf "$OBJTOP"

getcwd(3) will return with error since the directory is deleted.

Under this condition:

When shell is executing:

mkdir -p "$OBJTOP"

bear intercepts the libc exec(3) function call and call getcwd in here. As a result, it causes an error.

So... bear makes assumptions that are false and breaks perfectly fine build system code

jrtc27 added inline comments.Sat, Jan 17, 3:05 PM
tools/build/depend-cleanup.sh
254

Having said that, would changing this line to:

rm -rf "$OBJTOP"/* "$OBJTOP"/.[!.] "$OBJTOP"/.??*

also address the issue? That would avoid the need for the mkdir -p "$OBJTOP" on line 264 and be generally more friendly.

aokblast added a comment.EditedSun, Jan 18, 2:37 AM
In D54757#1251289, @jrtc27 wrote:
In D54757#1251288, @aokblast wrote:
In D54757#1251272, @jrtc27 wrote:

I don’t understand, other than it sounding like bear is broken

Sorry, the commit message is not clear. I try to explain with more detail. Please tell me if you need anymore information.

When

pwd == $OBJTOP

, and after

run rm -rf "$OBJTOP"

getcwd(3) will return with error since the directory is deleted.

Under this condition:

When shell is executing:

mkdir -p "$OBJTOP"

bear intercepts the libc exec(3) function call and call getcwd in here. As a result, it causes an error.

So... bear makes assumptions that are false and breaks perfectly fine build system code

Yes, you are right. In Bear, getcwd is used to format absolute path names. When a path is already absolute, the working-directory parameter can be optional. However, changing this behavior in Bear would require refactoring many files due to the deep call chain. I will give it a try when I have time.

tools/build/depend-cleanup.sh
254

Thanks! I am trying to run make buildworld. I will update the patch if it runs sucessfully.

aokblast updated this revision to Diff 169987.Sun, Jan 18, 5:32 AM

Delete content instead of removing the whole directory

Harbormaster completed remote builds in B69961: Diff 169987.Sun, Jan 18, 5:32 AM

Revision Contents
Changeset List

PathSize
tools/
build/
4 lines

Diff 169947

View Options

tools/build/depend-cleanup.sh

Loading...