Page MenuHomeFreeBSD

smartpqi: Avoid declaring extern inline functions
ClosedPublic

Authored by markj on Jan 15 2026, 5:03 PM.
Tags
None
Referenced Files
F169713374: D54732.id169827.diff
Wed, Sep 2, 8:53 AM
F169607701: D54732.id169827.diff
Wed, Sep 2, 1:29 AM
F169593697: D54732.id169796.diff
Wed, Sep 2, 12:39 AM
Unknown Object (File)
Tue, Sep 1, 8:12 AM
Unknown Object (File)
Mon, Aug 31, 11:54 PM
Unknown Object (File)
Mon, Aug 31, 1:43 AM
Unknown Object (File)
Mon, Aug 31, 12:44 AM
Unknown Object (File)
Sun, Aug 30, 7:56 AM
Subscribers
None

Details

Summary

Each C file is compiled separately so these functions can't be inlined
except in the file where they are defined. Since these functions aren't
used outside smartpqi_request.c, just do the simple thing and make them
private to that file.

Alternately, we can drop the inline annotation.

Reported by: gcc

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Jan 15 2026, 5:03 PM
markj created this revision.
sys/dev/smartpqi/smartpqi_request.c
1495

imp@ actually had an older patch that I missed and actually overwrote in 2f06449d64298fe508e3c585b45effd69a72d696 in which he made this just static.

1639

imp@ actually had an older patch that I missed and actually overwrote in 2f06449d64298fe508e3c585b45effd69a72d696 in which he made this just static.

Yea. inline often isn't needed these days...

sys/dev/smartpqi/smartpqi_request.c
1639

I Came here to say that :)

This revision is now accepted and ready to land.Jan 16 2026, 4:21 PM