Page MenuHomeFreeBSD

smartpqi: Avoid declaring extern inline functions
ClosedPublic

Authored by markj on Thu, Jan 15, 5:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 26, 1:24 PM
Unknown Object (File)
Sun, Jan 25, 1:22 PM
Unknown Object (File)
Sun, Jan 25, 11:21 AM
Unknown Object (File)
Sun, Jan 25, 11:21 AM
Unknown Object (File)
Sun, Jan 25, 11:20 AM
Unknown Object (File)
Sun, Jan 25, 8:21 AM
Unknown Object (File)
Sun, Jan 25, 6:40 AM
Unknown Object (File)
Sat, Jan 24, 9:19 PM
Subscribers
None

Details

Summary

Each C file is compiled separately so these functions can't be inlined
except in the file where they are defined. Since these functions aren't
used outside smartpqi_request.c, just do the simple thing and make them
private to that file.

Alternately, we can drop the inline annotation.

Reported by: gcc

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 69919
Build 66802: arc lint + arc unit

Event Timeline

markj requested review of this revision.Thu, Jan 15, 5:03 PM
markj created this revision.
sys/dev/smartpqi/smartpqi_request.c
1495

imp@ actually had an older patch that I missed and actually overwrote in 2f06449d64298fe508e3c585b45effd69a72d696 in which he made this just static.

1639

imp@ actually had an older patch that I missed and actually overwrote in 2f06449d64298fe508e3c585b45effd69a72d696 in which he made this just static.

Yea. inline often isn't needed these days...

sys/dev/smartpqi/smartpqi_request.c
1639

I Came here to say that :)

This revision is now accepted and ready to land.Fri, Jan 16, 4:21 PM