Page MenuHomeFreeBSD
Differential D6586

Fix ig4 operation for certain machines (from DragonFly)
ClosedPublic
Actions

Authored by grembo on May 27 2016, 1:10 AM.
Tags
None
Referenced Files
F106066186: D6586.diff
Tue, Dec 24, 7:56 PM
Unknown Object (File)
Sat, Nov 30, 6:32 AM
Unknown Object (File)
Nov 16 2024, 11:14 AM
Unknown Object (File)
Oct 27 2024, 2:13 PM
Unknown Object (File)
Oct 19 2024, 1:40 AM
Unknown Object (File)
Oct 5 2024, 5:53 PM
Unknown Object (File)
Oct 1 2024, 2:29 PM
Unknown Object (File)
Sep 30 2024, 3:54 AM
View All 66 Files
Subscribers
imp
pfg

Details

Reviewers
jhb
adrian
Commits
rS300990: Fix ig4 operation for certain machines
Summary

The ig4 driver was ported from DragonFly where the following
issues were found in the original driver:

  • Some machine BIOSes use the I2C bus and leave it in a state that causes interrupts to not work properly due to a pending interrupt having been latched.
  • Refactor the code a bit to clear pending interrupts when I2C is enabled. This fixes the primary problem.
  • Also fix a possible race condition in the interrupt handler where the interrupt was being cleared after reading the status instead of before.

I didn't experience those issues myself, but I received one user report
recently that sounded like it could've been caused by this issue.

It would be great to get this fix into 11.0-RELEASE before the code freeze
in two weeks from now.

Links to the original patch (thanks to @pfg for bringing this to my attention):

http://freshbsd.org/commit/dfbsd/2010e26953b9dc96ac7986666ce25b0fbe38f1ca
http://gitweb.dragonflybsd.org/dragonfly.git/commit/2010e26953b9dc96ac7986666ce25b0fbe38f1ca

Test Plan

Compiled, installed and made sure everything still worked as expected.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3983
Build 4026: arc lint + arc unit

Event Timeline

grembo updated this revision to Diff 16954.May 27 2016, 1:10 AM
grembo retitled this revision from to Fix ig4 operation for certain machines (from DragonFly).
grembo updated this object.
grembo edited the test plan for this revision. (Show Details)
grembo added reviewers: jhb, adrian.
grembo added a subscriber: pfg.
Herald added a subscriber: imp. · View Herald TranscriptMay 27 2016, 1:10 AM
jhb accepted this revision.May 27 2016, 4:28 PM
jhb edited edge metadata.

Approved once you fix the comment nit.

sys/dev/ichiic/ig4_iic.c
563

The comment should be moved with the code and possibly updated due to its new location.

This revision is now accepted and ready to land.May 27 2016, 4:28 PM
grembo updated this revision to Diff 17027.May 28 2016, 12:04 PM
grembo edited edge metadata.

Fix comment as pointed out by @jhb

This revision now requires review to proceed.May 28 2016, 12:04 PM
Closed by commit rS300990: Fix ig4 operation for certain machines (authored by grembo). · Explain WhyMay 30 2016, 9:05 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
dev/
ichiic/
12 lines

Diff 16954

View Options

sys/dev/ichiic/ig4_iic.c

Loading...