isl: Convert driver to CTLFLAG_MPSAFE
ClosedPublic
Actions

Authored by guest-seuros on Fri, Jan 9, 3:54 PM.

Details

Reviewers

jhb
imp
markj
grembo

Commits

rGda714e3e8537: isl: Convert driver to CTLFLAG_MPSAFE
rG0672e0e38a08: isl: Convert driver to CTLFLAG_MPSAFE

Summary

Replace CTLFLAG_NEEDGIANT with CTLFLAG_MPSAFE for all light sensor
sysctls. The driver uses iicbus_transfer for I2C access which
handles locking internally via the I2C bus layer.

Sysctls converted:

dev.isl.X.als (ambient light sensor)
dev.isl.X.ir (infrared sensor)
dev.isl.X.prox (proximity sensor)
dev.isl.X.resolution (sensor resolution)
dev.isl.X.range (sensor range)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 69756
Build 66639: arc lint + arc unit

Event Timeline

guest-seuros created this revision.Fri, Jan 9, 3:54 PM

guest-seuros held this revision as a draft.

Harbormaster completed remote builds in B69756: Diff 169392.Fri, Jan 9, 3:54 PM

guest-seuros published this revision for review.Fri, Jan 9, 3:58 PM

markj added a reviewer: grembo.Fri, Jan 9, 8:04 PM

markj accepted this revision.Mon, Jan 12, 12:51 AM

This revision is now accepted and ready to land.Mon, Jan 12, 12:51 AM

Closed by commit rG0672e0e38a08: isl: Convert driver to CTLFLAG_MPSAFE (authored by guest-seuros, committed by markj). · Explain WhyMon, Jan 12, 12:58 AM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG0672e0e38a08: isl: Convert driver to CTLFLAG_MPSAFE.

markj added a commit: rGda714e3e8537: isl: Convert driver to CTLFLAG_MPSAFE.Mon, Jan 26, 12:52 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

isl/

isl.c

10 lines

Diff 169392

View Options

isl: Convert driver to CTLFLAG_MPSAFEClosedPublicActions