Page MenuHomeFreeBSD
Differential D54436

asmc: improve asmc_dumpall to read actual SMC key count
ClosedPublic
Actions

Authored by guest-seuros on Wed, Dec 31, 3:06 PM.
Tags
None
Referenced Files
F142134402: D54436.id168967.diff
Fri, Jan 16, 8:52 AM
Unknown Object (File)
Fri, Jan 16, 2:44 AM
Unknown Object (File)
Fri, Jan 16, 1:43 AM
Unknown Object (File)
Fri, Jan 16, 12:49 AM
Unknown Object (File)
Thu, Jan 15, 4:23 AM
Unknown Object (File)
Wed, Jan 14, 11:19 AM
Unknown Object (File)
Tue, Jan 13, 1:58 AM
Unknown Object (File)
Sun, Jan 11, 8:02 PM
View All 25 Files
Subscribers
None

Details

Reviewers
imp
markj
adrian
Commits
rG2a7c4685b769: asmc: improve asmc_dumpall to read actual SMC key count
Summary

The asmc_dumpall debug function previously used a hardcoded loop limit of 0x100 (256) keys with a "XXX magic number" comment.

This change improves asmc_dumpall to:

  • Read the actual number of keys from the ASMC_NKEYS SMC key
  • Print the key count being dumped for better debugging output
  • Loop only up to the actual key count (e.g., 297 on Mac Mini 5,1)

This provides more accurate debug output and removes the magic number.

Test Plan

Tested on Mac Mini 5,1 (FreeBSD 16.0-CURRENT):

  1. Rebuild kernel with DEBUG enabled in asmc driver
  2. Boot with new kernel
  3. Verify dmesg shows "asmc_dumpall: dumping 297 keys" (or actual count)
  4. Verify all 297 keys are dumped

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

guest-seuros requested review of this revision.Wed, Dec 31, 3:06 PM
guest-seuros created this revision.
markj added inline comments.Wed, Dec 31, 4:30 PM
sys/dev/asmc/asmc.c
831

Did you consider reading this value once during driver attach time, and caching the result in the softc?

guest-seuros added a comment.Wed, Dec 31, 4:45 PM

Honestly no.

I will do it and update.

This code is in debug mode, so i did not consider optimization at all. I just needed the value printed once.

guest-seuros updated this revision to Diff 168806.Wed, Dec 31, 4:53 PM
adrian added a comment.Wed, Dec 31, 5:00 PM

oo neat, lemme go test this on my macbook air devices! thanks!

markj accepted this revision.Wed, Dec 31, 5:00 PM

This looks ok, thanks. Next time please upload patches with more context; see the comment about using -U99999 in https://wiki.freebsd.org/Phabricator#Create_a_Revision

sys/dev/asmc/asmc.c
927

Style nit, there should be a space after * in a type name: ntohl(*(uint32_t *)buf);

Also, it would be better to read the value into a uint32_t variable rather than a potentially unaligned buf.

This revision is now accepted and ready to land.Wed, Dec 31, 5:00 PM
adrian added inline comments.Fri, Jan 2, 7:20 PM
sys/dev/asmc/asmc.c
927

Yeah, I believe it should be something like be32dec(buf) ? That'll avoid the unaligned pointer cast/access and style nit in one hit.

guest-seuros updated this revision to Diff 168895.Fri, Jan 2, 7:37 PM
This revision now requires review to proceed.Fri, Jan 2, 7:37 PM
markj accepted this revision.Fri, Jan 2, 7:49 PM
markj added inline comments.
sys/dev/asmc/asmc.c
927

That works too.

This revision is now accepted and ready to land.Fri, Jan 2, 7:49 PM
Closed by commit rG2a7c4685b769: asmc: improve asmc_dumpall to read actual SMC key count (authored by guest-seuros, committed by adrian). · Explain WhySat, Jan 3, 6:49 PM
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rG2a7c4685b769: asmc: improve asmc_dumpall to read actual SMC key count.
guest-seuros mentioned this in D54666: asmc: Fix asmc_dumpall to enumerate all SMC keys.Mon, Jan 12, 9:07 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
asmc/
25 lines
1 line

Diff 168895

View Options

sys/dev/asmc/asmc.c

Loading...
View Options

sys/dev/asmc/asmcvar.h

Loading...